Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork

Configure Feed

Select the types of activity you want to include in your feed.

ARM: w1-gpio: fix erroneous gpio requests

Fix regression introduced by commit d2323cf773 ("onewire: w1-gpio: add
ext_pullup_enable pin in platform data") which added a gpio entry to the
platform data, but did not add the required initialisers to the board
files using it. Consequently, the driver would request gpio 0 at probe,
which could break other uses of the corresponding pin.

On AT91 requesting gpio 0 changes the pin muxing for PIOA0, which, for
instance, breaks SPI0 on at91sam9g20.

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Johan Hovold and committed by
Greg Kroah-Hartman
2d798a3f f6161aa1

+4
+1
arch/arm/mach-at91/board-foxg20.c
··· 176 176 /* If you choose to use a pin other than PB16 it needs to be 3.3V */ 177 177 .pin = AT91_PIN_PB16, 178 178 .is_open_drain = 1, 179 + .ext_pullup_enable_pin = -EINVAL, 179 180 }; 180 181 181 182 static struct platform_device w1_device = {
+1
arch/arm/mach-at91/board-stamp9g20.c
··· 188 188 static struct w1_gpio_platform_data w1_gpio_pdata = { 189 189 .pin = AT91_PIN_PA29, 190 190 .is_open_drain = 1, 191 + .ext_pullup_enable_pin = -EINVAL, 191 192 }; 192 193 193 194 static struct platform_device w1_device = {
+1
arch/arm/mach-ixp4xx/vulcan-setup.c
··· 163 163 164 164 static struct w1_gpio_platform_data vulcan_w1_gpio_pdata = { 165 165 .pin = 14, 166 + .ext_pullup_enable_pin = -EINVAL, 166 167 }; 167 168 168 169 static struct platform_device vulcan_w1_gpio = {
+1
arch/arm/mach-pxa/raumfeld.c
··· 505 505 .pin = GPIO_ONE_WIRE, 506 506 .is_open_drain = 0, 507 507 .enable_external_pullup = w1_enable_external_pullup, 508 + .ext_pullup_enable_pin = -EINVAL, 508 509 }; 509 510 510 511 struct platform_device raumfeld_w1_gpio_device = {