Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

RDMA/mlx4: Remove NULL check before dev_{put, hold}

The call netdev_{put, hold} of dev_{put, hold} will check NULL,
so there is no need to check before using dev_{put, hold}.

Fix the following coccicheck warnings:
/drivers/infiniband/hw/mlx4/main.c:1311:2-10: WARNING:
WARNING NULL check before dev_{put, hold} functions is not needed.

/drivers/infiniband/hw/mlx4/main.c:148:2-10: WARNING:
WARNING NULL check before dev_{put, hold} functions is not needed.

/drivers/infiniband/hw/mlx4/main.c:1959:3-11: WARNING:
WARNING NULL check before dev_{put, hold} functions is not needed.

/drivers/infiniband/hw/mlx4/main.c:1962:3-10: WARNING:
WARNING NULL check before dev_{put, hold} functions is not needed.

Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
Link: https://lore.kernel.org/r/202211291554079687539@zte.com.cn
Signed-off-by: Leon Romanovsky <leon@kernel.org>

authored by

zhang songyi and committed by
Leon Romanovsky
2d6c66f5 ea5ef136

+4 -8
+4 -8
drivers/infiniband/hw/mlx4/main.c
··· 144 144 } 145 145 } 146 146 } 147 - if (dev) 148 - dev_hold(dev); 147 + dev_hold(dev); 149 148 150 149 rcu_read_unlock(); 151 150 return dev; ··· 1306 1307 1307 1308 spin_lock_bh(&mdev->iboe.lock); 1308 1309 ndev = mdev->iboe.netdevs[mqp->port - 1]; 1309 - if (ndev) 1310 - dev_hold(ndev); 1310 + dev_hold(ndev); 1311 1311 spin_unlock_bh(&mdev->iboe.lock); 1312 1312 1313 1313 if (ndev) { ··· 1953 1955 if (ge) { 1954 1956 spin_lock_bh(&mdev->iboe.lock); 1955 1957 ndev = ge->added ? mdev->iboe.netdevs[ge->port - 1] : NULL; 1956 - if (ndev) 1957 - dev_hold(ndev); 1958 + dev_hold(ndev); 1958 1959 spin_unlock_bh(&mdev->iboe.lock); 1959 - if (ndev) 1960 - dev_put(ndev); 1960 + dev_put(ndev); 1961 1961 list_del(&ge->list); 1962 1962 kfree(ge); 1963 1963 } else