Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

platform/x86: panasonic-laptop: Replace snprintf in show functions with sysfs_emit

show() must not use snprintf() when formatting the value to be
returned to user space.

Fix the coccicheck warnings:
WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Signed-off-by: Qing Wang <wangqing@vivo.com>
Link: https://lore.kernel.org/r/1634280641-4862-1-git-send-email-wangqing@vivo.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

authored by

Qing Wang and committed by
Hans de Goede
2d5b0755 043449e7

+9 -9
+9 -9
drivers/platform/x86/panasonic-laptop.c
··· 470 470 if (!acpi_pcc_retrieve_biosdata(pcc)) 471 471 return -EIO; 472 472 473 - return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_NUM_BATTERIES]); 473 + return sysfs_emit(buf, "%u\n", pcc->sinf[SINF_NUM_BATTERIES]); 474 474 } 475 475 476 476 static ssize_t lcdtype_show(struct device *dev, struct device_attribute *attr, ··· 482 482 if (!acpi_pcc_retrieve_biosdata(pcc)) 483 483 return -EIO; 484 484 485 - return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_LCD_TYPE]); 485 + return sysfs_emit(buf, "%u\n", pcc->sinf[SINF_LCD_TYPE]); 486 486 } 487 487 488 488 static ssize_t mute_show(struct device *dev, struct device_attribute *attr, ··· 494 494 if (!acpi_pcc_retrieve_biosdata(pcc)) 495 495 return -EIO; 496 496 497 - return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_MUTE]); 497 + return sysfs_emit(buf, "%u\n", pcc->sinf[SINF_MUTE]); 498 498 } 499 499 500 500 static ssize_t mute_store(struct device *dev, struct device_attribute *attr, ··· 524 524 if (!acpi_pcc_retrieve_biosdata(pcc)) 525 525 return -EIO; 526 526 527 - return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sticky_key); 527 + return sysfs_emit(buf, "%u\n", pcc->sticky_key); 528 528 } 529 529 530 530 static ssize_t sticky_key_store(struct device *dev, struct device_attribute *attr, ··· 566 566 result = -EIO; 567 567 break; 568 568 } 569 - return snprintf(buf, PAGE_SIZE, "%u\n", result); 569 + return sysfs_emit(buf, "%u\n", result); 570 570 } 571 571 572 572 static ssize_t eco_mode_store(struct device *dev, struct device_attribute *attr, ··· 625 625 if (!acpi_pcc_retrieve_biosdata(pcc)) 626 626 return -EIO; 627 627 628 - return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_AC_CUR_BRIGHT]); 628 + return sysfs_emit(buf, "%u\n", pcc->sinf[SINF_AC_CUR_BRIGHT]); 629 629 } 630 630 631 631 static ssize_t ac_brightness_store(struct device *dev, struct device_attribute *attr, ··· 655 655 if (!acpi_pcc_retrieve_biosdata(pcc)) 656 656 return -EIO; 657 657 658 - return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_DC_CUR_BRIGHT]); 658 + return sysfs_emit(buf, "%u\n", pcc->sinf[SINF_DC_CUR_BRIGHT]); 659 659 } 660 660 661 661 static ssize_t dc_brightness_store(struct device *dev, struct device_attribute *attr, ··· 685 685 if (!acpi_pcc_retrieve_biosdata(pcc)) 686 686 return -EIO; 687 687 688 - return snprintf(buf, PAGE_SIZE, "%u\n", pcc->sinf[SINF_CUR_BRIGHT]); 688 + return sysfs_emit(buf, "%u\n", pcc->sinf[SINF_CUR_BRIGHT]); 689 689 } 690 690 691 691 static ssize_t current_brightness_store(struct device *dev, struct device_attribute *attr, ··· 710 710 static ssize_t cdpower_show(struct device *dev, struct device_attribute *attr, 711 711 char *buf) 712 712 { 713 - return snprintf(buf, PAGE_SIZE, "%d\n", get_optd_power_state()); 713 + return sysfs_emit(buf, "%d\n", get_optd_power_state()); 714 714 } 715 715 716 716 static ssize_t cdpower_store(struct device *dev, struct device_attribute *attr,