Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

blackfin: make-bf561/coreb.c explicitly non-modular

The Kconfig currently controlling compilation of this code is:

config BF561_COREB
bool "Enable Core B loader"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

Since module_misc_device translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.

Cc: Bas Vermeulen <bvermeul@blackstar.xs4all.nl>
Cc: Steven Miao <realmz6@gmail.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Paul Gortmaker and committed by
Greg Kroah-Hartman
2d4d3b5d 389b2a1c

+4 -6
+4 -6
arch/blackfin/mach-bf561/coreb.c
··· 1 1 /* Load firmware into Core B on a BF561 2 2 * 3 + * Author: Bas Vermeulen <bvermeul@blackstar.xs4all.nl> 4 + * 3 5 * Copyright 2004-2009 Analog Devices Inc. 4 6 * Licensed under the GPL-2 or later. 5 7 */ ··· 16 14 17 15 #include <linux/device.h> 18 16 #include <linux/fs.h> 17 + #include <linux/init.h> 19 18 #include <linux/kernel.h> 20 19 #include <linux/miscdevice.h> 21 - #include <linux/module.h> 22 20 23 21 #define CMD_COREB_START _IO('b', 0) 24 22 #define CMD_COREB_STOP _IO('b', 1) ··· 61 59 .name = "coreb", 62 60 .fops = &coreb_fops, 63 61 }; 64 - module_misc_device(coreb_dev); 65 - 66 - MODULE_AUTHOR("Bas Vermeulen <bvermeul@blackstar.xs4all.nl>"); 67 - MODULE_DESCRIPTION("BF561 Core B Support"); 68 - MODULE_LICENSE("GPL"); 62 + builtin_misc_device(coreb_dev);