Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spi: bcm63xx-spi: fix pm_runtime

The driver sets auto_runtime_pm to true, but it doesn't call
pm_runtime_enable(), which results in "Failed to power device" when PM support
is enabled.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Link: https://lore.kernel.org/r/20210223151851.4110-2-noltari@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Álvaro Fernández Rojas and committed by
Mark Brown
2d13f2ff 1d309cd6

+5 -1
+5 -1
drivers/spi/spi-bcm63xx.c
··· 593 593 594 594 bcm_spi_writeb(bs, SPI_INTR_CLEAR_ALL, SPI_INT_STATUS); 595 595 596 + pm_runtime_enable(&pdev->dev); 597 + 596 598 /* register and we are done */ 597 599 ret = devm_spi_register_master(dev, master); 598 600 if (ret) { 599 601 dev_err(dev, "spi register failed\n"); 600 - goto out_clk_disable; 602 + goto out_pm_disable; 601 603 } 602 604 603 605 dev_info(dev, "at %pr (irq %d, FIFOs size %d)\n", ··· 607 605 608 606 return 0; 609 607 608 + out_pm_disable: 609 + pm_runtime_disable(&pdev->dev); 610 610 out_clk_disable: 611 611 clk_disable_unprepare(clk); 612 612 out_err: