Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: scsi_ioctl: Remove scsi_req_init()

Merge scsi_req_init() into its only caller.

Link: https://lore.kernel.org/r/20210724072033.1284840-16-hch@lst.de
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Christoph Hellwig and committed by
Martin K. Petersen
2cece377 78011042

+6 -18
-15
block/scsi_ioctl.c
··· 817 817 } 818 818 EXPORT_SYMBOL(scsi_cmd_ioctl); 819 819 820 - /** 821 - * scsi_req_init - initialize certain fields of a scsi_request structure 822 - * @req: Pointer to a scsi_request structure. 823 - * Initializes .__cmd[], .cmd, .cmd_len and .sense_len but no other members 824 - * of struct scsi_request. 825 - */ 826 - void scsi_req_init(struct scsi_request *req) 827 - { 828 - memset(req->__cmd, 0, sizeof(req->__cmd)); 829 - req->cmd = req->__cmd; 830 - req->cmd_len = BLK_MAX_CDB; 831 - req->sense_len = 0; 832 - } 833 - EXPORT_SYMBOL(scsi_req_init); 834 - 835 820 static int __init blk_scsi_ioctl_init(void) 836 821 { 837 822 blk_set_cmd_filter_defaults(&blk_default_cmd_filter);
+6 -1
drivers/scsi/scsi_lib.c
··· 1083 1083 static void scsi_initialize_rq(struct request *rq) 1084 1084 { 1085 1085 struct scsi_cmnd *cmd = blk_mq_rq_to_pdu(rq); 1086 + struct scsi_request *req = &cmd->req; 1086 1087 1087 - scsi_req_init(&cmd->req); 1088 + memset(req->__cmd, 0, sizeof(req->__cmd)); 1089 + req->cmd = req->__cmd; 1090 + req->cmd_len = BLK_MAX_CDB; 1091 + req->sense_len = 0; 1092 + 1088 1093 init_rcu_head(&cmd->rcu); 1089 1094 cmd->jiffies_at_alloc = jiffies; 1090 1095 cmd->retries = 0;
-2
include/scsi/scsi_request.h
··· 28 28 kfree(req->cmd); 29 29 } 30 30 31 - void scsi_req_init(struct scsi_request *req); 32 - 33 31 #endif /* _SCSI_SCSI_REQUEST_H */