Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm: remove unused and redundant callbacks

Drivers no longer have any need for these callbacks, and there are no
users. Zap. Zap-zap-zzzap-p-pp-p.

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20170713162538.22788-15-peda@axentia.se

authored by

Peter Rosin and committed by
Daniel Vetter
2cd575aa 1c4a5d3a

-56
-8
include/drm/drm_crtc.h
··· 358 358 * drm_crtc_enable_color_mgmt(), which then supports the legacy gamma 359 359 * interface through the drm_atomic_helper_legacy_gamma_set() 360 360 * compatibility implementation. 361 - * 362 - * NOTE: 363 - * 364 - * Drivers that support gamma tables and also fbdev emulation through 365 - * the provided helper library need to take care to fill out the gamma 366 - * hooks for both. Currently there's a bit an unfortunate duplication 367 - * going on, which should eventually be unified to just one set of 368 - * hooks. 369 361 */ 370 362 int (*gamma_set)(struct drm_crtc *crtc, u16 *r, u16 *g, u16 *b, 371 363 uint32_t size,
-32
include/drm/drm_fb_helper.h
··· 85 85 */ 86 86 struct drm_fb_helper_funcs { 87 87 /** 88 - * @gamma_set: 89 - * 90 - * Set the given gamma LUT register on the given CRTC. 91 - * 92 - * This callback is optional. 93 - * 94 - * FIXME: 95 - * 96 - * This callback is functionally redundant with the core gamma table 97 - * support and simply exists because the fbdev hasn't yet been 98 - * refactored to use the core gamma table interfaces. 99 - */ 100 - void (*gamma_set)(struct drm_crtc *crtc, u16 red, u16 green, 101 - u16 blue, int regno); 102 - /** 103 - * @gamma_get: 104 - * 105 - * Read the given gamma LUT register on the given CRTC, used to save the 106 - * current LUT when force-restoring the fbdev for e.g. kdbg. 107 - * 108 - * This callback is optional. 109 - * 110 - * FIXME: 111 - * 112 - * This callback is functionally redundant with the core gamma table 113 - * support and simply exists because the fbdev hasn't yet been 114 - * refactored to use the core gamma table interfaces. 115 - */ 116 - void (*gamma_get)(struct drm_crtc *crtc, u16 *red, u16 *green, 117 - u16 *blue, int regno); 118 - 119 - /** 120 88 * @fb_probe: 121 89 * 122 90 * Driver callback to allocate and initialize the fbdev info structure.
-16
include/drm/drm_modeset_helper_vtables.h
··· 267 267 enum mode_set_atomic); 268 268 269 269 /** 270 - * @load_lut: 271 - * 272 - * Load a LUT prepared with the &drm_fb_helper_funcs.gamma_set vfunc. 273 - * 274 - * This callback is optional and is only used by the fbdev emulation 275 - * helpers. 276 - * 277 - * FIXME: 278 - * 279 - * This callback is functionally redundant with the core gamma table 280 - * support and simply exists because the fbdev hasn't yet been 281 - * refactored to use the core gamma table interfaces. 282 - */ 283 - void (*load_lut)(struct drm_crtc *crtc); 284 - 285 - /** 286 270 * @disable: 287 271 * 288 272 * This callback should be used to disable the CRTC. With the atomic