Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: rtl8192u: make in r819xU_firmware.c some local functions static

Make some local functions static (firmware_init_param, fw_download_code,
CPUcheck_maincodeok_turnonCPU and CPUcheck_firmware_ready) and fix
coding style in these function declarations when It is necessary.

Fixed the following sparse warnings in r819xU_firmware.c

CHECK drivers/staging/rtl8192u/r819xU_firmware.c
drivers/staging/rtl8192u/r819xU_firmware.c:20:6: warning: symbol 'firmware_init_param' was not declared. Should it be static?
drivers/staging/rtl8192u/r819xU_firmware.c:32:6: warning: symbol 'fw_download_code' was not declared. Should it be static?
drivers/staging/rtl8192u/r819xU_firmware.c:159:6: warning: symbol 'CPUcheck_maincodeok_turnonCPU' was not declared. Should it be static?
drivers/staging/rtl8192u/r819xU_firmware.c:208:6: warning: symbol 'CPUcheck_firmware_ready' was not declared. Should it be static?

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Ana Rey and committed by
Greg Kroah-Hartman
2cc817c0 280c4c8f

+6 -4
+6 -4
drivers/staging/rtl8192u/r819xU_firmware.c
··· 17 17 #include "r819xU_firmware_img.h" 18 18 #include "r819xU_firmware.h" 19 19 #include <linux/firmware.h> 20 - void firmware_init_param(struct net_device *dev) 20 + 21 + static void firmware_init_param(struct net_device *dev) 21 22 { 22 23 struct r8192_priv *priv = ieee80211_priv(dev); 23 24 rt_firmware *pfirmware = priv->pFirmware; ··· 30 29 * segment the img and use the ptr and length to remember info on each segment 31 30 * 32 31 */ 33 - bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, u32 buffer_len) 32 + static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, 33 + u32 buffer_len) 34 34 { 35 35 struct r8192_priv *priv = ieee80211_priv(dev); 36 36 bool rt_status = true; ··· 158 156 // NDIS_STATUS_FAILURE - the following initialization process should be terminated 159 157 // NDIS_STATUS_SUCCESS - if firmware initialization process success 160 158 //----------------------------------------------------------------------------- 161 - bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev) 159 + static bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev) 162 160 { 163 161 bool rt_status = true; 164 162 int check_putcodeOK_time = 200000, check_bootOk_time = 200000; ··· 207 205 return rt_status; 208 206 } 209 207 210 - bool CPUcheck_firmware_ready(struct net_device *dev) 208 + static bool CPUcheck_firmware_ready(struct net_device *dev) 211 209 { 212 210 213 211 bool rt_status = true;