tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

[PATCH] fix bogus argument of blkdev_put() in pktcdvd

final close of ->bdev should match the initial open, i.e.
get FMODE_READ | FMODE_NDELAY; FMODE_READ|FMODE_WRITE has
been a braino.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Al Viro 2cbed890 fc9161e5

+2 -2
unified split
+2 -2
drivers/block/pktcdvd.c
··· 2790 return 0; 2791 2792 out_mem: 2793 - blkdev_put(bdev, FMODE_READ|FMODE_WRITE); 2794 /* This is safe: open() is still holding a reference. */ 2795 module_put(THIS_MODULE); 2796 return ret; ··· 2975 pkt_debugfs_dev_remove(pd); 2976 pkt_sysfs_dev_remove(pd); 2977 2978 - blkdev_put(pd->bdev, FMODE_READ|FMODE_WRITE); 2979 2980 remove_proc_entry(pd->name, pkt_proc); 2981 DPRINTK(DRIVER_NAME": writer %s unmapped\n", pd->name);
··· 2790 return 0; 2791 2792 out_mem: 2793 + blkdev_put(bdev, FMODE_READ | FMODE_NDELAY); 2794 /* This is safe: open() is still holding a reference. */ 2795 module_put(THIS_MODULE); 2796 return ret; ··· 2975 pkt_debugfs_dev_remove(pd); 2976 pkt_sysfs_dev_remove(pd); 2977 2978 + blkdev_put(pd->bdev, FMODE_READ | FMODE_NDELAY); 2979 2980 remove_proc_entry(pd->name, pkt_proc); 2981 DPRINTK(DRIVER_NAME": writer %s unmapped\n", pd->name);