Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm: Fix deadlock due to getconnector locking changes

In commit ccfc08655d5fd5076828f45fb09194c070f2f63a
Author: Rob Clark <robdclark@gmail.com>
Date: Thu Dec 18 16:01:48 2014 -0500

drm: tweak getconnector locking

We need to extend the locking to cover connector->state reading for
atomic drivers, but the above commit was a bit too eager and also
included the fill_modes callback. Which on i915 on old platforms using
load detection needs to acquire modeset locks, resulting in a deadlock
on output probing.

Reported-by: Marc Finet <m.dreadlock@gmail.com>
Cc: Marc Finet <m.dreadlock@gmail.com>
Cc: robdclark@gmail.com
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>

authored by

Daniel Vetter and committed by
Dave Airlie
2caa80e7 c517d838

+2 -1
+2 -1
drivers/gpu/drm/drm_crtc.c
··· 2127 2127 DRM_DEBUG_KMS("[CONNECTOR:%d:?]\n", out_resp->connector_id); 2128 2128 2129 2129 mutex_lock(&dev->mode_config.mutex); 2130 - drm_modeset_lock(&dev->mode_config.connection_mutex, NULL); 2131 2130 2132 2131 connector = drm_connector_find(dev, out_resp->connector_id); 2133 2132 if (!connector) { ··· 2156 2157 out_resp->mm_height = connector->display_info.height_mm; 2157 2158 out_resp->subpixel = connector->display_info.subpixel_order; 2158 2159 out_resp->connection = connector->status; 2160 + 2161 + drm_modeset_lock(&dev->mode_config.connection_mutex, NULL); 2159 2162 encoder = drm_connector_get_encoder(connector); 2160 2163 if (encoder) 2161 2164 out_resp->encoder_id = encoder->base.id;