Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/vkms: Use offset-adjusted shadow-plane mappings and output

For framebuffers with non-zero offset fields, shadow-plane helpers
provide a pointer to the first byte of the contained data. Use it in
vkms.

Also provide use the offset-adjusted data address for the writeback
job's output buffers. Output framebuffers with non-zero offsets now
have their content written to the correct location.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210803125928.27780-12-tzimmermann@suse.de

+4 -3
+1 -1
drivers/gpu/drm/vkms/vkms_composer.c
··· 257 257 return; 258 258 259 259 if (wb_pending) 260 - vaddr_out = crtc_state->active_writeback->map[0].vaddr; 260 + vaddr_out = crtc_state->active_writeback->data[0].vaddr; 261 261 262 262 ret = compose_active_planes(&vaddr_out, primary_composer, 263 263 crtc_state);
+1
drivers/gpu/drm/vkms/vkms_drv.h
··· 22 22 23 23 struct vkms_writeback_job { 24 24 struct dma_buf_map map[DRM_FORMAT_MAX_PLANES]; 25 + struct dma_buf_map data[DRM_FORMAT_MAX_PLANES]; 25 26 }; 26 27 27 28 struct vkms_composer {
+1 -1
drivers/gpu/drm/vkms/vkms_plane.c
··· 111 111 memcpy(&composer->src, &new_state->src, sizeof(struct drm_rect)); 112 112 memcpy(&composer->dst, &new_state->dst, sizeof(struct drm_rect)); 113 113 memcpy(&composer->fb, fb, sizeof(struct drm_framebuffer)); 114 - memcpy(&composer->map, &shadow_plane_state->map, sizeof(composer->map)); 114 + memcpy(&composer->map, &shadow_plane_state->data, sizeof(composer->map)); 115 115 drm_framebuffer_get(&composer->fb); 116 116 composer->offset = fb->offsets[0]; 117 117 composer->pitch = fb->pitches[0];
+1 -1
drivers/gpu/drm/vkms/vkms_writeback.c
··· 75 75 if (!vkmsjob) 76 76 return -ENOMEM; 77 77 78 - ret = drm_gem_fb_vmap(job->fb, vkmsjob->map, NULL); 78 + ret = drm_gem_fb_vmap(job->fb, vkmsjob->map, vkmsjob->data); 79 79 if (ret) { 80 80 DRM_ERROR("vmap failed: %d\n", ret); 81 81 goto err_kfree;