Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

batman-adv: fix skb->data assignment

skb_linearize(skb) possibly rearranges the skb internal data and then changes
the skb->data pointer value. For this reason any other pointer in the code that
was assigned skb->data before invoking skb_linearise(skb) must be re-assigned.

In the current tt_query message handling code this is not done and therefore, in
case of skb linearization, the pointer used to handle the packet header ends up
in pointing to free'd memory.

This bug was introduced by a73105b8d4c765d9ebfb664d0a66802127d8e4c7
(batman-adv: improved client announcement mechanism)

Signed-off-by: Antonio Quartulli <ordex@autistici.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Antonio Quartulli and committed by
David S. Miller
2c995ff8 48d7d0ad

+2
+2
net/batman-adv/routing.c
··· 617 617 * changes */ 618 618 if (skb_linearize(skb) < 0) 619 619 goto out; 620 + /* skb_linearize() possibly changed skb->data */ 621 + tt_query = (struct tt_query_packet *)skb->data; 620 622 621 623 tt_len = tt_query->tt_data * sizeof(struct tt_change); 622 624