Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

xfrm: Fix NETDEV_DOWN with IPSec offload

Upon NETDEV_DOWN event, all xfrm_state objects which are bound to
the device are flushed.

The condition for this is wrong, though, testing dev->hw_features
instead of dev->features. If a device has non-user-modifiable
NETIF_F_HW_ESP, then its xfrm_state objects are not flushed,
causing a crash later on after the device is deleted.

Check dev->features instead of dev->hw_features.

Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API")
Signed-off-by: Ilan Tayari <ilant@mellanox.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>

authored by

Ilan Tayari and committed by
Steffen Klassert
2c1497bb d90c9024

+1 -1
+1 -1
net/xfrm/xfrm_device.c
··· 170 170 171 171 static int xfrm_dev_down(struct net_device *dev) 172 172 { 173 - if (dev->hw_features & NETIF_F_HW_ESP) 173 + if (dev->features & NETIF_F_HW_ESP) 174 174 xfrm_dev_state_flush(dev_net(dev), dev, true); 175 175 176 176 xfrm_garbage_collect(dev_net(dev));