Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests/powerpc: Fix argument order to timer_sub()

Commit c814bf958926 ("powerpc/selftests: Use timersub() for
gettimeofday()"), got the order of arguments to timersub() wrong,
leading to a negative time delta being reported, eg:

test: gettimeofday
tags: git_version:v6.12-rc5-409-gdddf291c3030
time = -3.297781
success: gettimeofday

The correct order is minuend, subtrahend, which in this case is end,
start. Which gives:

test: gettimeofday
tags: git_version:v6.12-rc5-409-gdddf291c3030-dirty
time = 3.300650
success: gettimeofday

Fixes: c814bf958926 ("powerpc/selftests: Use timersub() for gettimeofday()")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20241218114347.428108-1-mpe@ellerman.id.au

authored by

Michael Ellerman and committed by
Madhavan Srinivasan
2bf66e66 200f22fa

+1 -1
+1 -1
tools/testing/selftests/powerpc/benchmarks/gettimeofday.c
··· 20 20 gettimeofday(&tv_end, NULL); 21 21 } 22 22 23 - timersub(&tv_start, &tv_end, &tv_diff); 23 + timersub(&tv_end, &tv_start, &tv_diff); 24 24 25 25 printf("time = %.6f\n", tv_diff.tv_sec + (tv_diff.tv_usec) * 1e-6); 26 26