Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

lwtunnel: valid encap attr check should return 0 when lwtunnel is disabled

An error was reported upgrading to 4.9.8:
root@Typhoon:~# ip route add default table 210 nexthop dev eth0 via 10.68.64.1
weight 1 nexthop dev eth0 via 10.68.64.2 weight 1
RTNETLINK answers: Operation not supported

The problem occurs when CONFIG_LWTUNNEL is not enabled and a multipath
route is submitted.

The point of lwtunnel_valid_encap_type_attr is catch modules that
need to be loaded before any references are taken with rntl held. With
CONFIG_LWTUNNEL disabled, there will be no modules to load so the
lwtunnel_valid_encap_type_attr stub should just return 0.

Fixes: 9ed59592e3e3 ("lwtunnel: fix autoload of lwt modules")
Reported-by: pupilla@libero.it
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

David Ahern and committed by
David S. Miller
2bd137de a11a7f71

+4 -1
+4 -1
include/net/lwtunnel.h
··· 178 178 } 179 179 static inline int lwtunnel_valid_encap_type_attr(struct nlattr *attr, int len) 180 180 { 181 - return -EOPNOTSUPP; 181 + /* return 0 since we are not walking attr looking for 182 + * RTA_ENCAP_TYPE attribute on nexthops. 183 + */ 184 + return 0; 182 185 } 183 186 184 187 static inline int lwtunnel_build_state(struct net_device *dev, u16 encap_type,