tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

hwmon: (tmp401) Use constants for sysfs file permissions

Replace octal representation of file permissions by the corresponding
constants.

Signed-off-by: Andre Prendel <andre.prendel@gmx.de>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>

authored by

Andre Prendel and committed by
Jean Delvare 2b76d80a 87c33daa

+28 -22
+28 -22
drivers/hwmon/tmp401.c
··· 420 420 } 421 421 422 422 static struct sensor_device_attribute tmp401_attr[] = { 423 - SENSOR_ATTR(temp1_input, 0444, show_temp_value, NULL, 0), 424 - SENSOR_ATTR(temp1_min, 0644, show_temp_min, store_temp_min, 0), 425 - SENSOR_ATTR(temp1_max, 0644, show_temp_max, store_temp_max, 0), 426 - SENSOR_ATTR(temp1_crit, 0644, show_temp_crit, store_temp_crit, 0), 427 - SENSOR_ATTR(temp1_crit_hyst, 0644, show_temp_crit_hyst, 423 + SENSOR_ATTR(temp1_input, S_IRUGO, show_temp_value, NULL, 0), 424 + SENSOR_ATTR(temp1_min, S_IWUSR | S_IRUGO, show_temp_min, 425 + store_temp_min, 0), 426 + SENSOR_ATTR(temp1_max, S_IWUSR | S_IRUGO, show_temp_max, 427 + store_temp_max, 0), 428 + SENSOR_ATTR(temp1_crit, S_IWUSR | S_IRUGO, show_temp_crit, 429 + store_temp_crit, 0), 430 + SENSOR_ATTR(temp1_crit_hyst, S_IWUSR | S_IRUGO, show_temp_crit_hyst, 428 431 store_temp_crit_hyst, 0), 429 - SENSOR_ATTR(temp1_min_alarm, 0444, show_status, NULL, 432 + SENSOR_ATTR(temp1_min_alarm, S_IRUGO, show_status, NULL, 430 433 TMP401_STATUS_LOCAL_LOW), 431 - SENSOR_ATTR(temp1_max_alarm, 0444, show_status, NULL, 434 + SENSOR_ATTR(temp1_max_alarm, S_IRUGO, show_status, NULL, 432 435 TMP401_STATUS_LOCAL_HIGH), 433 - SENSOR_ATTR(temp1_crit_alarm, 0444, show_status, NULL, 436 + SENSOR_ATTR(temp1_crit_alarm, S_IRUGO, show_status, NULL, 434 437 TMP401_STATUS_LOCAL_CRIT), 435 - SENSOR_ATTR(temp2_input, 0444, show_temp_value, NULL, 1), 436 - SENSOR_ATTR(temp2_min, 0644, show_temp_min, store_temp_min, 1), 437 - SENSOR_ATTR(temp2_max, 0644, show_temp_max, store_temp_max, 1), 438 - SENSOR_ATTR(temp2_crit, 0644, show_temp_crit, store_temp_crit, 1), 439 - SENSOR_ATTR(temp2_crit_hyst, 0444, show_temp_crit_hyst, NULL, 1), 440 - SENSOR_ATTR(temp2_fault, 0444, show_status, NULL, 438 + SENSOR_ATTR(temp2_input, S_IRUGO, show_temp_value, NULL, 1), 439 + SENSOR_ATTR(temp2_min, S_IWUSR | S_IRUGO, show_temp_min, 440 + store_temp_min, 1), 441 + SENSOR_ATTR(temp2_max, S_IWUSR | S_IRUGO, show_temp_max, 442 + store_temp_max, 1), 443 + SENSOR_ATTR(temp2_crit, S_IWUSR | S_IRUGO, show_temp_crit, 444 + store_temp_crit, 1), 445 + SENSOR_ATTR(temp2_crit_hyst, S_IRUGO, show_temp_crit_hyst, NULL, 1), 446 + SENSOR_ATTR(temp2_fault, S_IRUGO, show_status, NULL, 441 447 TMP401_STATUS_REMOTE_OPEN), 442 - SENSOR_ATTR(temp2_min_alarm, 0444, show_status, NULL, 448 + SENSOR_ATTR(temp2_min_alarm, S_IRUGO, show_status, NULL, 443 449 TMP401_STATUS_REMOTE_LOW), 444 - SENSOR_ATTR(temp2_max_alarm, 0444, show_status, NULL, 450 + SENSOR_ATTR(temp2_max_alarm, S_IRUGO, show_status, NULL, 445 451 TMP401_STATUS_REMOTE_HIGH), 446 - SENSOR_ATTR(temp2_crit_alarm, 0444, show_status, NULL, 452 + SENSOR_ATTR(temp2_crit_alarm, S_IRUGO, show_status, NULL, 447 453 TMP401_STATUS_REMOTE_CRIT), 448 454 }; 449 455 ··· 461 455 * and remote channels. 462 456 */ 463 457 static struct sensor_device_attribute tmp411_attr[] = { 464 - SENSOR_ATTR(temp1_highest, 0444, show_temp_highest, NULL, 0), 465 - SENSOR_ATTR(temp1_lowest, 0444, show_temp_lowest, NULL, 0), 466 - SENSOR_ATTR(temp2_highest, 0444, show_temp_highest, NULL, 1), 467 - SENSOR_ATTR(temp2_lowest, 0444, show_temp_lowest, NULL, 1), 468 - SENSOR_ATTR(temp_reset_history, 0200, NULL, reset_temp_history, 0), 458 + SENSOR_ATTR(temp1_highest, S_IRUGO, show_temp_highest, NULL, 0), 459 + SENSOR_ATTR(temp1_lowest, S_IRUGO, show_temp_lowest, NULL, 0), 460 + SENSOR_ATTR(temp2_highest, S_IRUGO, show_temp_highest, NULL, 1), 461 + SENSOR_ATTR(temp2_lowest, S_IRUGO, show_temp_lowest, NULL, 1), 462 + SENSOR_ATTR(temp_reset_history, S_IWUSR, NULL, reset_temp_history, 0), 469 463 }; 470 464 471 465 /*