Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

bpf, i386: Remove unneeded conversion to bool

The '==' expression itself is bool, no need to convert it to bool again.
This fixes the following coccicheck warning:

arch/x86/net/bpf_jit_comp32.c:1478:50-55: WARNING: conversion to bool not needed here
arch/x86/net/bpf_jit_comp32.c:1479:50-55: WARNING: conversion to bool not needed here

Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/bpf/20200506140352.37154-1-yanaijie@huawei.com

authored by

Jason Yan and committed by
Daniel Borkmann
2b6c6f07 f87b87a1

+2 -2
+2 -2
arch/x86/net/bpf_jit_comp32.c
··· 1475 1475 for (i = 0; i < insn_cnt; i++, insn++) { 1476 1476 const s32 imm32 = insn->imm; 1477 1477 const bool is64 = BPF_CLASS(insn->code) == BPF_ALU64; 1478 - const bool dstk = insn->dst_reg == BPF_REG_AX ? false : true; 1479 - const bool sstk = insn->src_reg == BPF_REG_AX ? false : true; 1478 + const bool dstk = insn->dst_reg != BPF_REG_AX; 1479 + const bool sstk = insn->src_reg != BPF_REG_AX; 1480 1480 const u8 code = insn->code; 1481 1481 const u8 *dst = bpf2ia32[insn->dst_reg]; 1482 1482 const u8 *src = bpf2ia32[insn->src_reg];