Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Input: pxa27x_keypad - remove an unneeded NULL check

Static checkers complain about this NULL check because we dereference it
without checking a couple lines later. This function is only called
when "keypad->pdata" is non-NULL so we can just delete the NULL test.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
[Dmitry: remove the variable altogether given that it is used just once and
dereference directly.]
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Dan Carpenter and committed by
Dmitry Torokhov
2b2f5147 791738be

+1 -3
+1 -3
drivers/input/keyboard/pxa27x_keypad.c
··· 345 345 { 346 346 const struct pxa27x_keypad_platform_data *pdata = keypad->pdata; 347 347 struct input_dev *input_dev = keypad->input_dev; 348 - const struct matrix_keymap_data *keymap_data = 349 - pdata ? pdata->matrix_keymap_data : NULL; 350 348 unsigned short keycode; 351 349 int i; 352 350 int error; 353 351 354 - error = matrix_keypad_build_keymap(keymap_data, NULL, 352 + error = matrix_keypad_build_keymap(pdata->matrix_keymap_data, NULL, 355 353 pdata->matrix_key_rows, 356 354 pdata->matrix_key_cols, 357 355 keypad->keycodes, input_dev);