Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rt2x00: Endless loop on hub port power down

I've met an endless (or at least very long) loop if I power down the usb
port on witch a usb wifi key is plugged.
(Ok, it's not very smart to power down a usb port when a usb key is in
used... but still, I think that should not lead to an endless loop).

I have a lot of:
ieee80211 phy1: rt2x00usb_vendor_request: Error - Vendor Request 0x07 failed for offset 0x0438 with error -71

(-71==-EPROTO)

How to reproduce:
- plug an usb wifi key
- ip link set wlan0 up
- hub-ctrl -b usb_bus -d usb_device -P usb_port -p 0

hub-ctrl source: https://github.com/codazoda/hub-ctrl.c/blob/master/hub-ctrl.c

The following patch prevents the endless loop, but I'm really not sure
that The Right Way To Do It (R)

Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

authored by

Richard Genoud and committed by
John W. Linville
2ad69ac5 5c2b6078

+6
+6
drivers/net/wireless/rt2x00/rt2x00usb.c
··· 68 68 } 69 69 } 70 70 71 + /* If the port is powered down, we get a -EPROTO error, and this 72 + * leads to a endless loop. So just say that the device is gone. 73 + */ 74 + if (status == -EPROTO) 75 + clear_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags); 76 + 71 77 rt2x00_err(rt2x00dev, 72 78 "Vendor Request 0x%02x failed for offset 0x%04x with error %d\n", 73 79 request, offset, status);