Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

88pm860x_battery: Convert to using managed resources

Use managed resource functions devm_request_threaded_irq and
devm_power_supply_register to simplify error handling.

To be compatible with the change, various gotos are replaced
with direct returns and unneeded labels are dropped. Also,
remove pm860x_battery_remove as it is now redundant.

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>

authored by

Vaishali Thakkar and committed by
Sebastian Reichel
2a9123f1 56d7df87

+11 -26
+11 -26
drivers/power/88pm860x_battery.c
··· 954 954 else 955 955 info->resistor = 300; /* set default internal resistor */ 956 956 957 - info->battery = power_supply_register(&pdev->dev, &pm860x_battery_desc, 958 - NULL); 957 + info->battery = devm_power_supply_register(&pdev->dev, 958 + &pm860x_battery_desc, 959 + NULL); 959 960 if (IS_ERR(info->battery)) 960 961 return PTR_ERR(info->battery); 961 962 info->battery->dev.parent = &pdev->dev; 962 963 963 - ret = request_threaded_irq(info->irq_cc, NULL, 964 - pm860x_coulomb_handler, IRQF_ONESHOT, 965 - "coulomb", info); 964 + ret = devm_request_threaded_irq(chip->dev, info->irq_cc, NULL, 965 + pm860x_coulomb_handler, IRQF_ONESHOT, 966 + "coulomb", info); 966 967 if (ret < 0) { 967 968 dev_err(chip->dev, "Failed to request IRQ: #%d: %d\n", 968 969 info->irq_cc, ret); 969 - goto out_reg; 970 + return ret; 970 971 } 971 972 972 - ret = request_threaded_irq(info->irq_batt, NULL, pm860x_batt_handler, 973 - IRQF_ONESHOT, "battery", info); 973 + ret = devm_request_threaded_irq(chip->dev, info->irq_batt, NULL, 974 + pm860x_batt_handler, 975 + IRQF_ONESHOT, "battery", info); 974 976 if (ret < 0) { 975 977 dev_err(chip->dev, "Failed to request IRQ: #%d: %d\n", 976 978 info->irq_batt, ret); 977 - goto out_coulomb; 979 + return ret; 978 980 } 979 981 980 982 981 - return 0; 982 - 983 - out_coulomb: 984 - free_irq(info->irq_cc, info); 985 - out_reg: 986 - power_supply_unregister(info->battery); 987 - return ret; 988 - } 989 - 990 - static int pm860x_battery_remove(struct platform_device *pdev) 991 - { 992 - struct pm860x_battery_info *info = platform_get_drvdata(pdev); 993 - 994 - free_irq(info->irq_batt, info); 995 - free_irq(info->irq_cc, info); 996 - power_supply_unregister(info->battery); 997 983 return 0; 998 984 } 999 985 ··· 1014 1028 .pm = &pm860x_battery_pm_ops, 1015 1029 }, 1016 1030 .probe = pm860x_battery_probe, 1017 - .remove = pm860x_battery_remove, 1018 1031 }; 1019 1032 module_platform_driver(pm860x_battery_driver); 1020 1033