Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

irqchip/armada-370-xp: Fix ack/eoi breakage

When converting the driver to using handle_percpu_devid_irq,
we forgot to repaint the irq_eoi() callback into irq_ack(),
as handle_percpu_devid_fasteoi_ipi() was actually using EOI
really early in the handling. Yes this was a stupid idea.

Fix this by using the HW ack method as irq_ack().

Fixes: e52e73b7e9f7 ("irqchip/armada-370-xp: Make IPIs use handle_percpu_devid_irq()")
Reported-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Tested-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Cc: Valentin Schneider <valentin.schneider@arm.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/87tuiexq5f.fsf@pengutronix.de

+2 -2
+2 -2
drivers/irqchip/irq-armada-370-xp.c
··· 359 359 ARMADA_370_XP_SW_TRIG_INT_OFFS); 360 360 } 361 361 362 - static void armada_370_xp_ipi_eoi(struct irq_data *d) 362 + static void armada_370_xp_ipi_ack(struct irq_data *d) 363 363 { 364 364 writel(~BIT(d->hwirq), per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_CAUSE_OFFS); 365 365 } 366 366 367 367 static struct irq_chip ipi_irqchip = { 368 368 .name = "IPI", 369 + .irq_ack = armada_370_xp_ipi_ack, 369 370 .irq_mask = armada_370_xp_ipi_mask, 370 371 .irq_unmask = armada_370_xp_ipi_unmask, 371 - .irq_eoi = armada_370_xp_ipi_eoi, 372 372 .ipi_send_mask = armada_370_xp_ipi_send_mask, 373 373 }; 374 374