Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it

REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.

Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.

Therefore, change the use of "depends on REGMAP_MMIO" to
"select REGMAP_MMIO", which will also set REGMAP.

Fixes: eb994594bc22 ("ipmi: bt-bmc: Use a regmap for register access")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Jeffery <andrew@aj.id.au>
Cc: Corey Minyard <minyard@acm.org>
Cc: openipmi-developer@lists.sourceforge.net
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Message-Id: <20230226053953.4681-2-rdunlap@infradead.org>
Signed-off-by: Corey Minyard <cminyard@mvista.com>

authored by

Randy Dunlap and committed by
Corey Minyard
2a587b9a 98281842

+2 -1
+2 -1
drivers/char/ipmi/Kconfig
··· 162 162 163 163 config ASPEED_BT_IPMI_BMC 164 164 depends on ARCH_ASPEED || COMPILE_TEST 165 - depends on REGMAP && REGMAP_MMIO && MFD_SYSCON 165 + depends on MFD_SYSCON 166 + select REGMAP_MMIO 166 167 tristate "BT IPMI bmc driver" 167 168 help 168 169 Provides a driver for the BT (Block Transfer) IPMI interface