Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spi: cadence: Add of_node_put() before return

Fix following coccicheck warning:
./drivers/spi/spi-cadence-xspi.c:490:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before return

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20211015033919.5915-1-wanjiabing@vivo.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Wan Jiabing and committed by
Mark Brown
2a4a4e89 dbf641a1

+2
+2
drivers/spi/spi-cadence-xspi.c
··· 493 493 494 494 if (of_property_read_u32(node_child, "reg", &cs)) { 495 495 dev_err(&pdev->dev, "Couldn't get memory chip select\n"); 496 + of_node_put(node_child); 496 497 return -ENXIO; 497 498 } else if (cs >= CDNS_XSPI_MAX_BANKS) { 498 499 dev_err(&pdev->dev, "reg (cs) parameter value too large\n"); 500 + of_node_put(node_child); 499 501 return -ENXIO; 500 502 } 501 503 }