Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/vblank: Add FIXME comments about moving the vblank ts hooks

This is going to be a bit too much, but good to have at least a small
note about where this should all head towards.

Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170509140329.24114-3-daniel.vetter@ffwll.ch

+10
+10
include/drm/drm_drv.h
··· 276 276 * constant but unknown small number of scanlines wrt. real scanout 277 277 * position. 278 278 * 279 + * FIXME: 280 + * 281 + * Since this is a helper to implement @get_vblank_timestamp, we should 282 + * move it to &struct drm_crtc_helper_funcs, like all the other 283 + * helper-internal hooks. 279 284 */ 280 285 int (*get_scanout_position) (struct drm_device *dev, unsigned int pipe, 281 286 unsigned int flags, int *vpos, int *hpos, ··· 324 319 * 325 320 * True on success, false on failure, which means the core should 326 321 * fallback to a simple timestamp taken in drm_crtc_handle_vblank(). 322 + * 323 + * FIXME: 324 + * 325 + * We should move this hook to &struct drm_crtc_funcs like all the other 326 + * vblank hooks. 327 327 */ 328 328 bool (*get_vblank_timestamp) (struct drm_device *dev, unsigned int pipe, 329 329 int *max_error,