Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests/powerpc: Test for spurious kernel memory faults on radix

Previously when mapping kernel memory on radix, no ptesync was
included which would periodically lead to unhandled spurious faults.
Mapping kernel memory is used when code patching with Strict RWX
enabled. As suggested by Chris Riedl, turning ftrace on and off does a
large amount of code patching so is a convenient way to see this kind
of fault.

Add a selftest to try and trigger this kind of a spurious fault. It
tests for 30 seconds which is usually long enough for the issue to
show up.

Signed-off-by: Jordan Niethe <jniethe5@gmail.com>
[mpe: Rename it to better reflect what it does, rather than the symptom]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210208032957.1232102-2-jniethe5@gmail.com

authored by

Jordan Niethe and committed by
Michael Ellerman
29e3ea8c b8b2f37c

+50
+1
tools/testing/selftests/powerpc/mm/Makefile
··· 5 5 TEST_GEN_PROGS := hugetlb_vs_thp_test subpage_prot prot_sao segv_errors wild_bctr \ 6 6 large_vm_fork_separation bad_accesses pkey_exec_prot \ 7 7 pkey_siginfo stack_expansion_signal stack_expansion_ldst 8 + TEST_PROGS := stress_code_patching.sh 8 9 9 10 TEST_GEN_PROGS_EXTENDED := tlbie_test 10 11 TEST_GEN_FILES := tempfile
+49
tools/testing/selftests/powerpc/mm/stress_code_patching.sh
··· 1 + #!/bin/bash 2 + # SPDX-License-Identifier: GPL-2.0-or-later 3 + 4 + TIMEOUT=30 5 + 6 + DEBUFS_DIR=`cat /proc/mounts | grep debugfs | awk '{print $2}'` 7 + if [ ! -e "$DEBUFS_DIR" ] 8 + then 9 + echo "debugfs not found, skipping" 1>&2 10 + exit 4 11 + fi 12 + 13 + if [ ! -e "$DEBUFS_DIR/tracing/current_tracer" ] 14 + then 15 + echo "Tracing files not found, skipping" 1>&2 16 + exit 4 17 + fi 18 + 19 + 20 + echo "Testing for spurious faults when mapping kernel memory..." 21 + 22 + if grep -q "FUNCTION TRACING IS CORRUPTED" "$DEBUFS_DIR/tracing/trace" 23 + then 24 + echo "FAILED: Ftrace already dead. Probably due to a spurious fault" 1>&2 25 + exit 1 26 + fi 27 + 28 + dmesg -C 29 + START_TIME=`date +%s` 30 + END_TIME=`expr $START_TIME + $TIMEOUT` 31 + while [ `date +%s` -lt $END_TIME ] 32 + do 33 + echo function > $DEBUFS_DIR/tracing/current_tracer 34 + echo nop > $DEBUFS_DIR/tracing/current_tracer 35 + if dmesg | grep -q 'ftrace bug' 36 + then 37 + break 38 + fi 39 + done 40 + 41 + echo nop > $DEBUFS_DIR/tracing/current_tracer 42 + if dmesg | grep -q 'ftrace bug' 43 + then 44 + echo "FAILED: Mapping kernel memory causes spurious faults" 1>&2 45 + exit 1 46 + else 47 + echo "OK: Mapping kernel memory does not cause spurious faults" 48 + exit 0 49 + fi