Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: qrtr: free memory on error path in radix_tree_insert()

Function radix_tree_insert() returns errors if the node hasn't
been initialized and added to the tree.

"kfree(node)" and return value "NULL" of node_get() help
to avoid using unclear node in other calls.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Cc: <stable@vger.kernel.org> # 5.7
Fixes: 0c2204a4ad71 ("net: qrtr: Migrate nameservice to kernel from userspace")
Signed-off-by: Natalia Petrova <n.petrova@fintech.ru>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Link: https://lore.kernel.org/r/20230125134831.8090-1-n.petrova@fintech.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Natalia Petrova and committed by
Jakub Kicinski
29de68c2 14caefcf

+4 -1
+4 -1
net/qrtr/ns.c
··· 83 83 84 84 node->id = node_id; 85 85 86 - radix_tree_insert(&nodes, node_id, node); 86 + if (radix_tree_insert(&nodes, node_id, node)) { 87 + kfree(node); 88 + return NULL; 89 + } 87 90 88 91 return node; 89 92 }