Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: renesas_usbhs: Fix DMAC sequence for receiving zero-length packet

The DREQE bit of the DnFIFOSEL should be set to 1 after the DE bit of
USB-DMAC on R-Car SoCs is set to 1 after the USB-DMAC received a
zero-length packet. Otherwise, a transfer completion interruption
of USB-DMAC doesn't happen. Even if the driver changes the sequence,
normal operations (transmit/receive without zero-length packet) will
not cause any side-effects. So, this patch fixes the sequence anyway.

Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
[shimoda: revise the commit log]
Fixes: e73a9891b3a1 ("usb: renesas_usbhs: add DMAEngine support")
Cc: <stable@vger.kernel.org> # v3.1+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

authored by

Kazuya Mizuguchi and committed by
Felipe Balbi
29c7f3e6 ab219221

+1 -1
+1 -1
drivers/usb/renesas_usbhs/fifo.c
··· 857 857 fifo->name, usbhs_pipe_number(pipe), pkt->length, pkt->zero); 858 858 859 859 usbhs_pipe_running(pipe, 1); 860 - usbhsf_dma_start(pipe, fifo); 861 860 usbhs_pipe_set_trans_count_if_bulk(pipe, pkt->trans); 862 861 dma_async_issue_pending(chan); 862 + usbhsf_dma_start(pipe, fifo); 863 863 usbhs_pipe_enable(pipe); 864 864 865 865 xfer_work_end: