Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] em28xx: use usb_interface for dev_foo() calls

The usb_device->dev is not the right device for dev_foo() calls.
Instead, it should use usb_interface->dev.

Tested-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

authored by

Mauro Carvalho Chehab and committed by
Mauro Carvalho Chehab
29b05e22 ea48c368

+216 -213
+17 -17
drivers/media/usb/em28xx/em28xx-audio.c
··· 56 56 57 57 #define dprintk(fmt, arg...) do { \ 58 58 if (debug) \ 59 - dev_printk(KERN_DEBUG, &dev->udev->dev, \ 59 + dev_printk(KERN_DEBUG, &dev->intf->dev, \ 60 60 "video: %s: " fmt, __func__, ## arg); \ 61 61 } while (0) 62 62 ··· 166 166 167 167 status = usb_submit_urb(urb, GFP_ATOMIC); 168 168 if (status < 0) 169 - dev_err(&dev->udev->dev, 169 + dev_err(&dev->intf->dev, 170 170 "resubmit of audio urb failed (error=%i)\n", 171 171 status); 172 172 return; ··· 185 185 186 186 errCode = usb_submit_urb(dev->adev.urb[i], GFP_ATOMIC); 187 187 if (errCode) { 188 - dev_err(&dev->udev->dev, 188 + dev_err(&dev->intf->dev, 189 189 "submit of audio urb failed (error=%i)\n", 190 190 errCode); 191 191 em28xx_deinit_isoc_audio(dev); ··· 322 322 err: 323 323 mutex_unlock(&dev->lock); 324 324 325 - dev_err(&dev->udev->dev, 325 + dev_err(&dev->intf->dev, 326 326 "Error while configuring em28xx mixer\n"); 327 327 return ret; 328 328 } ··· 761 761 intf = usb_ifnum_to_if(dev->udev, dev->ifnum); 762 762 763 763 if (intf->num_altsetting <= alt) { 764 - dev_err(&dev->udev->dev, "alt %d doesn't exist on interface %d\n", 764 + dev_err(&dev->intf->dev, "alt %d doesn't exist on interface %d\n", 765 765 dev->ifnum, alt); 766 766 return -ENODEV; 767 767 } ··· 777 777 } 778 778 779 779 if (!ep) { 780 - dev_err(&dev->udev->dev, "Couldn't find an audio endpoint"); 780 + dev_err(&dev->intf->dev, "Couldn't find an audio endpoint"); 781 781 return -ENODEV; 782 782 } 783 783 784 784 ep_size = em28xx_audio_ep_packet_size(dev->udev, ep); 785 785 interval = 1 << (ep->bInterval - 1); 786 786 787 - dev_info(&dev->udev->dev, 787 + dev_info(&dev->intf->dev, 788 788 "Endpoint 0x%02x %s on intf %d alt %d interval = %d, size %d\n", 789 789 EM28XX_EP_AUDIO, usb_speed_string(dev->udev->speed), 790 790 dev->ifnum, alt, interval, ep_size); ··· 824 824 if (urb_size > ep_size * npackets) 825 825 npackets = DIV_ROUND_UP(urb_size, ep_size); 826 826 827 - dev_info(&dev->udev->dev, 827 + dev_info(&dev->intf->dev, 828 828 "Number of URBs: %d, with %d packets and %d size\n", 829 829 num_urb, npackets, urb_size); 830 830 ··· 863 863 buf = usb_alloc_coherent(dev->udev, npackets * ep_size, GFP_ATOMIC, 864 864 &urb->transfer_dma); 865 865 if (!buf) { 866 - dev_err(&dev->udev->dev, 866 + dev_err(&dev->intf->dev, 867 867 "usb_alloc_coherent failed!\n"); 868 868 em28xx_audio_free_urb(dev); 869 869 return -ENOMEM; ··· 904 904 return 0; 905 905 } 906 906 907 - dev_info(&dev->udev->dev, "Binding audio extension\n"); 907 + dev_info(&dev->intf->dev, "Binding audio extension\n"); 908 908 909 909 kref_get(&dev->ref); 910 910 911 - dev_info(&dev->udev->dev, 911 + dev_info(&dev->intf->dev, 912 912 "em28xx-audio.c: Copyright (C) 2006 Markus Rechberger\n"); 913 - dev_info(&dev->udev->dev, 913 + dev_info(&dev->intf->dev, 914 914 "em28xx-audio.c: Copyright (C) 2007-2016 Mauro Carvalho Chehab\n"); 915 915 916 - err = snd_card_new(&dev->udev->dev, index[devnr], "Em28xx Audio", 916 + err = snd_card_new(&dev->intf->dev, index[devnr], "Em28xx Audio", 917 917 THIS_MODULE, 0, &card); 918 918 if (err < 0) 919 919 return err; ··· 961 961 if (err < 0) 962 962 goto urb_free; 963 963 964 - dev_info(&dev->udev->dev, "Audio extension successfully initialized\n"); 964 + dev_info(&dev->intf->dev, "Audio extension successfully initialized\n"); 965 965 return 0; 966 966 967 967 urb_free: ··· 986 986 return 0; 987 987 } 988 988 989 - dev_info(&dev->udev->dev, "Closing audio extension\n"); 989 + dev_info(&dev->intf->dev, "Closing audio extension\n"); 990 990 991 991 if (dev->adev.sndcard) { 992 992 snd_card_disconnect(dev->adev.sndcard); ··· 1010 1010 if (dev->usb_audio_type != EM28XX_USB_AUDIO_VENDOR) 1011 1011 return 0; 1012 1012 1013 - dev_info(&dev->udev->dev, "Suspending audio extension\n"); 1013 + dev_info(&dev->intf->dev, "Suspending audio extension\n"); 1014 1014 em28xx_deinit_isoc_audio(dev); 1015 1015 atomic_set(&dev->adev.stream_started, 0); 1016 1016 return 0; ··· 1024 1024 if (dev->usb_audio_type != EM28XX_USB_AUDIO_VENDOR) 1025 1025 return 0; 1026 1026 1027 - dev_info(&dev->udev->dev, "Resuming audio extension\n"); 1027 + dev_info(&dev->intf->dev, "Resuming audio extension\n"); 1028 1028 /* Nothing to do other than schedule_work() ?? */ 1029 1029 schedule_work(&dev->adev.wq_trigger); 1030 1030 return 0;
+15 -15
drivers/media/usb/em28xx/em28xx-camera.c
··· 121 121 ret = i2c_master_send(&client, &reg, 1); 122 122 if (ret < 0) { 123 123 if (ret != -ENXIO) 124 - dev_err(&dev->udev->dev, 124 + dev_err(&dev->intf->dev, 125 125 "couldn't read from i2c device 0x%02x: error %i\n", 126 126 client.addr << 1, ret); 127 127 continue; 128 128 } 129 129 ret = i2c_master_recv(&client, (u8 *)&id_be, 2); 130 130 if (ret < 0) { 131 - dev_err(&dev->udev->dev, 131 + dev_err(&dev->intf->dev, 132 132 "couldn't read from i2c device 0x%02x: error %i\n", 133 133 client.addr << 1, ret); 134 134 continue; ··· 138 138 reg = 0xff; 139 139 ret = i2c_master_send(&client, &reg, 1); 140 140 if (ret < 0) { 141 - dev_err(&dev->udev->dev, 141 + dev_err(&dev->intf->dev, 142 142 "couldn't read from i2c device 0x%02x: error %i\n", 143 143 client.addr << 1, ret); 144 144 continue; 145 145 } 146 146 ret = i2c_master_recv(&client, (u8 *)&id_be, 2); 147 147 if (ret < 0) { 148 - dev_err(&dev->udev->dev, 148 + dev_err(&dev->intf->dev, 149 149 "couldn't read from i2c device 0x%02x: error %i\n", 150 150 client.addr << 1, ret); 151 151 continue; ··· 185 185 dev->em28xx_sensor = EM28XX_MT9M001; 186 186 break; 187 187 default: 188 - dev_info(&dev->udev->dev, 188 + dev_info(&dev->intf->dev, 189 189 "unknown Micron sensor detected: 0x%04x\n", id); 190 190 return 0; 191 191 } 192 192 193 193 if (dev->em28xx_sensor == EM28XX_NOSENSOR) 194 - dev_info(&dev->udev->dev, 194 + dev_info(&dev->intf->dev, 195 195 "unsupported sensor detected: %s\n", name); 196 196 else 197 - dev_info(&dev->udev->dev, 197 + dev_info(&dev->intf->dev, 198 198 "sensor %s detected\n", name); 199 199 200 200 dev->i2c_client[dev->def_i2c_bus].addr = client.addr; ··· 225 225 ret = i2c_smbus_read_byte_data(&client, reg); 226 226 if (ret < 0) { 227 227 if (ret != -ENXIO) 228 - dev_err(&dev->udev->dev, 228 + dev_err(&dev->intf->dev, 229 229 "couldn't read from i2c device 0x%02x: error %i\n", 230 230 client.addr << 1, ret); 231 231 continue; ··· 234 234 reg = 0x1d; 235 235 ret = i2c_smbus_read_byte_data(&client, reg); 236 236 if (ret < 0) { 237 - dev_err(&dev->udev->dev, 237 + dev_err(&dev->intf->dev, 238 238 "couldn't read from i2c device 0x%02x: error %i\n", 239 239 client.addr << 1, ret); 240 240 continue; ··· 247 247 reg = 0x0a; 248 248 ret = i2c_smbus_read_byte_data(&client, reg); 249 249 if (ret < 0) { 250 - dev_err(&dev->udev->dev, 250 + dev_err(&dev->intf->dev, 251 251 "couldn't read from i2c device 0x%02x: error %i\n", 252 252 client.addr << 1, ret); 253 253 continue; ··· 256 256 reg = 0x0b; 257 257 ret = i2c_smbus_read_byte_data(&client, reg); 258 258 if (ret < 0) { 259 - dev_err(&dev->udev->dev, 259 + dev_err(&dev->intf->dev, 260 260 "couldn't read from i2c device 0x%02x: error %i\n", 261 261 client.addr << 1, ret); 262 262 continue; ··· 296 296 name = "OV9655"; 297 297 break; 298 298 default: 299 - dev_info(&dev->udev->dev, 299 + dev_info(&dev->intf->dev, 300 300 "unknown OmniVision sensor detected: 0x%04x\n", 301 301 id); 302 302 return 0; 303 303 } 304 304 305 305 if (dev->em28xx_sensor == EM28XX_NOSENSOR) 306 - dev_info(&dev->udev->dev, 306 + dev_info(&dev->intf->dev, 307 307 "unsupported sensor detected: %s\n", name); 308 308 else 309 - dev_info(&dev->udev->dev, 309 + dev_info(&dev->intf->dev, 310 310 "sensor %s detected\n", name); 311 311 312 312 dev->i2c_client[dev->def_i2c_bus].addr = client.addr; ··· 331 331 */ 332 332 333 333 if (dev->em28xx_sensor == EM28XX_NOSENSOR && ret < 0) { 334 - dev_info(&dev->udev->dev, 334 + dev_info(&dev->intf->dev, 335 335 "No sensor detected\n"); 336 336 return -ENODEV; 337 337 }
+31 -30
drivers/media/usb/em28xx/em28xx-cards.c
··· 2677 2677 msleep(50); 2678 2678 } 2679 2679 2680 - dev_warn(&dev->udev->dev, "AC97 registers access is not reliable !\n"); 2680 + dev_warn(&dev->intf->dev, "AC97 registers access is not reliable !\n"); 2681 2681 return -ETIMEDOUT; 2682 2682 } 2683 2683 ··· 2831 2831 dev->model = em28xx_eeprom_hash[i].model; 2832 2832 dev->tuner_type = em28xx_eeprom_hash[i].tuner; 2833 2833 2834 - dev_err(&dev->udev->dev, 2834 + dev_err(&dev->intf->dev, 2835 2835 "Your board has no unique USB ID.\n" 2836 2836 "A hint were successfully done, based on eeprom hash.\n" 2837 2837 "This method is not 100%% failproof.\n" ··· 2861 2861 if (dev->i2c_hash == em28xx_i2c_hash[i].hash) { 2862 2862 dev->model = em28xx_i2c_hash[i].model; 2863 2863 dev->tuner_type = em28xx_i2c_hash[i].tuner; 2864 - dev_err(&dev->udev->dev, 2864 + dev_err(&dev->intf->dev, 2865 2865 "Your board has no unique USB ID.\n" 2866 2866 "A hint were successfully done, based on i2c devicelist hash.\n" 2867 2867 "This method is not 100%% failproof.\n" ··· 2874 2874 } 2875 2875 } 2876 2876 2877 - dev_err(&dev->udev->dev, 2877 + dev_err(&dev->intf->dev, 2878 2878 "Your board has no unique USB ID and thus need a hint to be detected.\n" 2879 2879 "You may try to use card=<n> insmod option to workaround that.\n" 2880 2880 "Please send an email with this log to:\n" ··· 2883 2883 "Board i2c devicelist hash is 0x%08lx\n", 2884 2884 dev->hash, dev->i2c_hash); 2885 2885 2886 - dev_err(&dev->udev->dev, 2886 + dev_err(&dev->intf->dev, 2887 2887 "Here is a list of valid choices for the card=<n> insmod option:\n"); 2888 2888 for (i = 0; i < em28xx_bcount; i++) { 2889 - dev_err(&dev->udev->dev, 2889 + dev_err(&dev->intf->dev, 2890 2890 " card=%d -> %s\n", i, em28xx_boards[i].name); 2891 2891 } 2892 2892 return -1; ··· 2921 2921 * hash identities which has not been determined as yet. 2922 2922 */ 2923 2923 if (em28xx_hint_board(dev) < 0) 2924 - dev_err(&dev->udev->dev, "Board not discovered\n"); 2924 + dev_err(&dev->intf->dev, "Board not discovered\n"); 2925 2925 else { 2926 2926 em28xx_set_model(dev); 2927 2927 em28xx_pre_card_setup(dev); ··· 2931 2931 em28xx_set_model(dev); 2932 2932 } 2933 2933 2934 - dev_info(&dev->udev->dev, "Identified as %s (card=%d)\n", 2934 + dev_info(&dev->intf->dev, "Identified as %s (card=%d)\n", 2935 2935 dev->board.name, dev->model); 2936 2936 2937 2937 dev->tuner_type = em28xx_boards[dev->model].tuner_type; ··· 3030 3030 } 3031 3031 3032 3032 if (dev->board.valid == EM28XX_BOARD_NOT_VALIDATED) { 3033 - dev_err(&dev->udev->dev, 3033 + dev_err(&dev->intf->dev, 3034 3034 "\n\n" 3035 3035 "The support for this board weren't valid yet.\n" 3036 3036 "Please send a report of having this working\n" ··· 3161 3161 else if (udev->manufacturer) 3162 3162 media_device_usb_init(mdev, udev, udev->manufacturer); 3163 3163 else 3164 - media_device_usb_init(mdev, udev, dev_name(&dev->udev->dev)); 3164 + media_device_usb_init(mdev, udev, dev_name(&dev->intf->dev)); 3165 3165 3166 3166 dev->media_dev = mdev; 3167 3167 #endif ··· 3217 3217 { 3218 3218 struct em28xx *dev = kref_to_dev(ref); 3219 3219 3220 - dev_info(&dev->udev->dev, "Freeing device\n"); 3220 + dev_info(&dev->intf->dev, "Freeing device\n"); 3221 3221 3222 3222 if (!dev->disconnected) 3223 3223 em28xx_release_resources(dev); ··· 3239 3239 const char *chip_name = NULL; 3240 3240 3241 3241 dev->udev = udev; 3242 + dev->intf = interface; 3242 3243 mutex_init(&dev->ctrl_urb_lock); 3243 3244 spin_lock_init(&dev->slock); 3244 3245 ··· 3325 3324 } 3326 3325 } 3327 3326 if (!chip_name) 3328 - dev_info(&dev->udev->dev, 3327 + dev_info(&dev->intf->dev, 3329 3328 "unknown em28xx chip ID (%d)\n", dev->chip_id); 3330 3329 else 3331 - dev_info(&dev->udev->dev, "chip ID is %s\n", chip_name); 3330 + dev_info(&dev->intf->dev, "chip ID is %s\n", chip_name); 3332 3331 3333 3332 em28xx_media_device_init(dev, udev); 3334 3333 ··· 3347 3346 /* Resets I2C speed */ 3348 3347 retval = em28xx_write_reg(dev, EM28XX_R06_I2C_CLK, dev->board.i2c_speed); 3349 3348 if (retval < 0) { 3350 - dev_err(&dev->udev->dev, 3349 + dev_err(&dev->intf->dev, 3351 3350 "%s: em28xx_write_reg failed! retval [%d]\n", 3352 3351 __func__, retval); 3353 3352 return retval; ··· 3362 3361 else 3363 3362 retval = em28xx_i2c_register(dev, 0, EM28XX_I2C_ALGO_EM28XX); 3364 3363 if (retval < 0) { 3365 - dev_err(&dev->udev->dev, 3364 + dev_err(&dev->intf->dev, 3366 3365 "%s: em28xx_i2c_register bus 0 - error [%d]!\n", 3367 3366 __func__, retval); 3368 3367 return retval; ··· 3377 3376 retval = em28xx_i2c_register(dev, 1, 3378 3377 EM28XX_I2C_ALGO_EM28XX); 3379 3378 if (retval < 0) { 3380 - dev_err(&dev->udev->dev, 3379 + dev_err(&dev->intf->dev, 3381 3380 "%s: em28xx_i2c_register bus 1 - error [%d]!\n", 3382 3381 __func__, retval); 3383 3382 ··· 3418 3417 nr = find_first_zero_bit(em28xx_devused, EM28XX_MAXBOARDS); 3419 3418 if (nr >= EM28XX_MAXBOARDS) { 3420 3419 /* No free device slots */ 3421 - dev_err(&udev->dev, 3420 + dev_err(&interface->dev, 3422 3421 "Driver supports up to %i em28xx boards.\n", 3423 3422 EM28XX_MAXBOARDS); 3424 3423 retval = -ENOMEM; ··· 3428 3427 3429 3428 /* Don't register audio interfaces */ 3430 3429 if (interface->altsetting[0].desc.bInterfaceClass == USB_CLASS_AUDIO) { 3431 - dev_err(&udev->dev, 3430 + dev_err(&interface->dev, 3432 3431 "audio device (%04x:%04x): interface %i, class %i\n", 3433 3432 le16_to_cpu(udev->descriptor.idVendor), 3434 3433 le16_to_cpu(udev->descriptor.idProduct), ··· 3489 3488 if (usb_endpoint_xfer_isoc(e)) { 3490 3489 has_vendor_audio = true; 3491 3490 } else { 3492 - dev_err(&udev->dev, 3491 + dev_err(&interface->dev, 3493 3492 "error: skipping audio endpoint 0x83, because it uses bulk transfers !\n"); 3494 3493 } 3495 3494 break; ··· 3563 3562 speed = "unknown"; 3564 3563 } 3565 3564 3566 - dev_err(&udev->dev, 3565 + dev_err(&interface->dev, 3567 3566 "New device %s %s @ %s Mbps (%04x:%04x, interface %d, class %d)\n", 3568 3567 udev->manufacturer ? udev->manufacturer : "", 3569 3568 udev->product ? udev->product : "", ··· 3579 3578 * not enough even for most Digital TV streams. 3580 3579 */ 3581 3580 if (udev->speed != USB_SPEED_HIGH && disable_usb_speed_check == 0) { 3582 - dev_err(&udev->dev, "Device initialization failed.\n"); 3583 - dev_err(&udev->dev, 3581 + dev_err(&interface->dev, "Device initialization failed.\n"); 3582 + dev_err(&interface->dev, 3584 3583 "Device must be connected to a high-speed USB 2.0 port.\n"); 3585 3584 retval = -ENODEV; 3586 3585 goto err_free; ··· 3594 3593 dev->ifnum = ifnum; 3595 3594 3596 3595 if (has_vendor_audio) { 3597 - dev_err(&udev->dev, 3596 + dev_err(&interface->dev, 3598 3597 "Audio interface %i found (Vendor Class)\n", ifnum); 3599 3598 dev->usb_audio_type = EM28XX_USB_AUDIO_VENDOR; 3600 3599 } ··· 3604 3603 3605 3604 if (uif->altsetting[0].desc.bInterfaceClass == USB_CLASS_AUDIO) { 3606 3605 if (has_vendor_audio) 3607 - dev_err(&udev->dev, 3606 + dev_err(&interface->dev, 3608 3607 "em28xx: device seems to have vendor AND usb audio class interfaces !\n" 3609 3608 "\t\tThe vendor interface will be ignored. Please contact the developers <linux-media@vger.kernel.org>\n"); 3610 3609 dev->usb_audio_type = EM28XX_USB_AUDIO_CLASS; ··· 3613 3612 } 3614 3613 3615 3614 if (has_video) 3616 - dev_err(&udev->dev, "Video interface %i found:%s%s\n", 3615 + dev_err(&interface->dev, "Video interface %i found:%s%s\n", 3617 3616 ifnum, 3618 3617 dev->analog_ep_bulk ? " bulk" : "", 3619 3618 dev->analog_ep_isoc ? " isoc" : ""); 3620 3619 if (has_dvb) 3621 - dev_err(&udev->dev, "DVB interface %i found:%s%s\n", 3620 + dev_err(&interface->dev, "DVB interface %i found:%s%s\n", 3622 3621 ifnum, 3623 3622 dev->dvb_ep_bulk ? " bulk" : "", 3624 3623 dev->dvb_ep_isoc ? " isoc" : ""); ··· 3650 3649 /* Disable V4L2 if the device doesn't have a decoder */ 3651 3650 if (has_video && 3652 3651 dev->board.decoder == EM28XX_NODECODER && !dev->board.is_webcam) { 3653 - dev_err(&udev->dev, 3652 + dev_err(&interface->dev, 3654 3653 "Currently, V4L2 is not supported on this model\n"); 3655 3654 has_video = false; 3656 3655 dev->has_video = false; ··· 3660 3659 if (has_video) { 3661 3660 if (!dev->analog_ep_isoc || (try_bulk && dev->analog_ep_bulk)) 3662 3661 dev->analog_xfer_bulk = 1; 3663 - dev_err(&udev->dev, "analog set to %s mode.\n", 3662 + dev_err(&interface->dev, "analog set to %s mode.\n", 3664 3663 dev->analog_xfer_bulk ? "bulk" : "isoc"); 3665 3664 } 3666 3665 if (has_dvb) { 3667 3666 if (!dev->dvb_ep_isoc || (try_bulk && dev->dvb_ep_bulk)) 3668 3667 dev->dvb_xfer_bulk = 1; 3669 - dev_err(&udev->dev, "dvb set to %s mode.\n", 3668 + dev_err(&interface->dev, "dvb set to %s mode.\n", 3670 3669 dev->dvb_xfer_bulk ? "bulk" : "isoc"); 3671 3670 } 3672 3671 ··· 3714 3713 3715 3714 dev->disconnected = 1; 3716 3715 3717 - dev_err(&dev->udev->dev, "Disconnecting\n"); 3716 + dev_err(&dev->intf->dev, "Disconnecting\n"); 3718 3717 3719 3718 flush_request_modules(dev); 3720 3719
+24 -24
drivers/media/usb/em28xx/em28xx-core.c
··· 52 52 53 53 #define em28xx_coredbg(fmt, arg...) do { \ 54 54 if (core_debug) \ 55 - dev_printk(KERN_DEBUG, &dev->udev->dev, \ 55 + dev_printk(KERN_DEBUG, &dev->intf->dev, \ 56 56 "core: %s: " fmt, __func__, ## arg); \ 57 57 } while (0) 58 58 ··· 63 63 64 64 #define em28xx_regdbg(fmt, arg...) do { \ 65 65 if (reg_debug) \ 66 - dev_printk(KERN_DEBUG, &dev->udev->dev, \ 66 + dev_printk(KERN_DEBUG, &dev->intf->dev, \ 67 67 "reg: %s: " fmt, __func__, ## arg); \ 68 68 } while (0) 69 69 70 70 /* FIXME: don't abuse core_debug */ 71 71 #define em28xx_isocdbg(fmt, arg...) do { \ 72 72 if (core_debug) \ 73 - dev_printk(KERN_DEBUG, &dev->udev->dev, \ 73 + dev_printk(KERN_DEBUG, &dev->intf->dev, \ 74 74 "core: %s: " fmt, __func__, ## arg); \ 75 75 } while (0) 76 76 ··· 258 258 msleep(5); 259 259 } 260 260 261 - dev_warn(&dev->udev->dev, 261 + dev_warn(&dev->intf->dev, 262 262 "AC97 command still being executed: not handled properly!\n"); 263 263 return -EBUSY; 264 264 } ··· 352 352 ret = em28xx_write_ac97(dev, inputs[i].reg, 0x8000); 353 353 354 354 if (ret < 0) 355 - dev_warn(&dev->udev->dev, 355 + dev_warn(&dev->intf->dev, 356 356 "couldn't setup AC97 register %d\n", 357 357 inputs[i].reg); 358 358 } ··· 437 437 for (i = 0; i < ARRAY_SIZE(outputs); i++) { 438 438 ret = em28xx_write_ac97(dev, outputs[i].reg, 0x8000); 439 439 if (ret < 0) 440 - dev_warn(&dev->udev->dev, 440 + dev_warn(&dev->intf->dev, 441 441 "couldn't setup AC97 register %d\n", 442 442 outputs[i].reg); 443 443 } ··· 476 476 ret = em28xx_write_ac97(dev, outputs[i].reg, 477 477 vol); 478 478 if (ret < 0) 479 - dev_warn(&dev->udev->dev, 479 + dev_warn(&dev->intf->dev, 480 480 "couldn't setup AC97 register %d\n", 481 481 outputs[i].reg); 482 482 } ··· 514 514 515 515 /* See how this device is configured */ 516 516 cfg = em28xx_read_reg(dev, EM28XX_R00_CHIPCFG); 517 - dev_info(&dev->udev->dev, "Config register raw data: 0x%02x\n", cfg); 517 + dev_info(&dev->intf->dev, "Config register raw data: 0x%02x\n", cfg); 518 518 if (cfg < 0) { /* Register read error */ 519 519 /* Be conservative */ 520 520 dev->int_audio_type = EM28XX_INT_AUDIO_AC97; ··· 535 535 i2s_samplerates = 5; 536 536 else 537 537 i2s_samplerates = 3; 538 - dev_info(&dev->udev->dev, "I2S Audio (%d sample rate(s))\n", 538 + dev_info(&dev->intf->dev, "I2S Audio (%d sample rate(s))\n", 539 539 i2s_samplerates); 540 540 /* Skip the code that does AC97 vendor detection */ 541 541 dev->audio_mode.ac97 = EM28XX_NO_AC97; ··· 553 553 * Note: (some) em2800 devices without eeprom reports 0x91 on 554 554 * CHIPCFG register, even not having an AC97 chip 555 555 */ 556 - dev_warn(&dev->udev->dev, 556 + dev_warn(&dev->intf->dev, 557 557 "AC97 chip type couldn't be determined\n"); 558 558 dev->audio_mode.ac97 = EM28XX_NO_AC97; 559 559 if (dev->usb_audio_type == EM28XX_USB_AUDIO_VENDOR) ··· 567 567 goto init_audio; 568 568 569 569 vid = vid1 << 16 | vid2; 570 - dev_warn(&dev->udev->dev, "AC97 vendor ID = 0x%08x\n", vid); 570 + dev_warn(&dev->intf->dev, "AC97 vendor ID = 0x%08x\n", vid); 571 571 572 572 feat = em28xx_read_ac97(dev, AC97_RESET); 573 573 if (feat < 0) 574 574 goto init_audio; 575 575 576 - dev_warn(&dev->udev->dev, "AC97 features = 0x%04x\n", feat); 576 + dev_warn(&dev->intf->dev, "AC97 features = 0x%04x\n", feat); 577 577 578 578 /* Try to identify what audio processor we have */ 579 579 if (((vid == 0xffffffff) || (vid == 0x83847650)) && (feat == 0x6a90)) ··· 585 585 /* Reports detected AC97 processor */ 586 586 switch (dev->audio_mode.ac97) { 587 587 case EM28XX_NO_AC97: 588 - dev_info(&dev->udev->dev, "No AC97 audio processor\n"); 588 + dev_info(&dev->intf->dev, "No AC97 audio processor\n"); 589 589 break; 590 590 case EM28XX_AC97_EM202: 591 - dev_info(&dev->udev->dev, 591 + dev_info(&dev->intf->dev, 592 592 "Empia 202 AC97 audio processor detected\n"); 593 593 break; 594 594 case EM28XX_AC97_SIGMATEL: 595 - dev_info(&dev->udev->dev, 595 + dev_info(&dev->intf->dev, 596 596 "Sigmatel audio processor detected (stac 97%02x)\n", 597 597 vid & 0xff); 598 598 break; 599 599 case EM28XX_AC97_OTHER: 600 - dev_warn(&dev->udev->dev, 600 + dev_warn(&dev->intf->dev, 601 601 "Unknown AC97 audio processor detected!\n"); 602 602 break; 603 603 default: ··· 882 882 if (mode == EM28XX_DIGITAL_MODE) { 883 883 if ((xfer_bulk && !dev->dvb_ep_bulk) || 884 884 (!xfer_bulk && !dev->dvb_ep_isoc)) { 885 - dev_err(&dev->udev->dev, 885 + dev_err(&dev->intf->dev, 886 886 "no endpoint for DVB mode and transfer type %d\n", 887 887 xfer_bulk > 0); 888 888 return -EINVAL; ··· 891 891 } else if (mode == EM28XX_ANALOG_MODE) { 892 892 if ((xfer_bulk && !dev->analog_ep_bulk) || 893 893 (!xfer_bulk && !dev->analog_ep_isoc)) { 894 - dev_err(&dev->udev->dev, 894 + dev_err(&dev->intf->dev, 895 895 "no endpoint for analog mode and transfer type %d\n", 896 896 xfer_bulk > 0); 897 897 return -EINVAL; 898 898 } 899 899 usb_bufs = &dev->usb_ctl.analog_bufs; 900 900 } else { 901 - dev_err(&dev->udev->dev, "invalid mode selected\n"); 901 + dev_err(&dev->intf->dev, "invalid mode selected\n"); 902 902 return -EINVAL; 903 903 } 904 904 ··· 940 940 usb_bufs->transfer_buffer[i] = usb_alloc_coherent(dev->udev, 941 941 sb_size, GFP_KERNEL, &urb->transfer_dma); 942 942 if (!usb_bufs->transfer_buffer[i]) { 943 - dev_err(&dev->udev->dev, 943 + dev_err(&dev->intf->dev, 944 944 "unable to allocate %i bytes for transfer buffer %i%s\n", 945 945 sb_size, i, 946 946 in_interrupt() ? " while in int" : ""); ··· 1023 1023 if (xfer_bulk) { 1024 1024 rc = usb_clear_halt(dev->udev, usb_bufs->urb[0]->pipe); 1025 1025 if (rc < 0) { 1026 - dev_err(&dev->udev->dev, 1026 + dev_err(&dev->intf->dev, 1027 1027 "failed to clear USB bulk endpoint stall/halt condition (error=%i)\n", 1028 1028 rc); 1029 1029 em28xx_uninit_usb_xfer(dev, mode); ··· 1040 1040 for (i = 0; i < usb_bufs->num_bufs; i++) { 1041 1041 rc = usb_submit_urb(usb_bufs->urb[i], GFP_ATOMIC); 1042 1042 if (rc) { 1043 - dev_err(&dev->udev->dev, 1043 + dev_err(&dev->intf->dev, 1044 1044 "submit of urb %i failed (error=%i)\n", i, rc); 1045 1045 em28xx_uninit_usb_xfer(dev, mode); 1046 1046 return rc; ··· 1123 1123 { 1124 1124 const struct em28xx_ops *ops = NULL; 1125 1125 1126 - dev_info(&dev->udev->dev, "Suspending extensions\n"); 1126 + dev_info(&dev->intf->dev, "Suspending extensions\n"); 1127 1127 mutex_lock(&em28xx_devlist_mutex); 1128 1128 list_for_each_entry(ops, &em28xx_extension_devlist, next) { 1129 1129 if (ops->suspend) ··· 1137 1137 { 1138 1138 const struct em28xx_ops *ops = NULL; 1139 1139 1140 - dev_info(&dev->udev->dev, "Resuming extensions\n"); 1140 + dev_info(&dev->intf->dev, "Resuming extensions\n"); 1141 1141 mutex_lock(&em28xx_devlist_mutex); 1142 1142 list_for_each_entry(ops, &em28xx_extension_devlist, next) { 1143 1143 if (ops->resume)
+31 -30
drivers/media/usb/em28xx/em28xx-dvb.c
··· 75 75 76 76 #define dprintk(level, fmt, arg...) do { \ 77 77 if (debug >= level) \ 78 - dev_printk(KERN_DEBUG, &dev->udev->dev, \ 78 + dev_printk(KERN_DEBUG, &dev->intf->dev, \ 79 79 "dvb: " fmt, ## arg); \ 80 80 } while (0) 81 81 ··· 736 736 737 737 ret = gpio_request_one(dvb->lna_gpio, flags, NULL); 738 738 if (ret) 739 - dev_err(&dev->udev->dev, "gpio request failed %d\n", ret); 739 + dev_err(&dev->intf->dev, "gpio request failed %d\n", ret); 740 740 else 741 741 gpio_free(dvb->lna_gpio); 742 742 743 743 return ret; 744 744 #else 745 - dev_warn(&dev->udev->dev, "%s: LNA control is disabled (lna=%u)\n", 745 + dev_warn(&dev->intf->dev, "%s: LNA control is disabled (lna=%u)\n", 746 746 KBUILD_MODNAME, c->lna); 747 747 return 0; 748 748 #endif ··· 936 936 cfg.ctrl = &ctl; 937 937 938 938 if (!dev->dvb->fe[0]) { 939 - dev_err(&dev->udev->dev, 939 + dev_err(&dev->intf->dev, 940 940 "dvb frontend not attached. Can't attach xc3028\n"); 941 941 return -EINVAL; 942 942 } 943 943 944 944 fe = dvb_attach(xc2028_attach, dev->dvb->fe[0], &cfg); 945 945 if (!fe) { 946 - dev_err(&dev->udev->dev, "xc3028 attach failed\n"); 946 + dev_err(&dev->intf->dev, "xc3028 attach failed\n"); 947 947 dvb_frontend_detach(dev->dvb->fe[0]); 948 948 dev->dvb->fe[0] = NULL; 949 949 return -EINVAL; 950 950 } 951 951 952 - dev_info(&dev->udev->dev, "xc3028 attached\n"); 952 + dev_info(&dev->intf->dev, "xc3028 attached\n"); 953 953 954 954 return 0; 955 955 } ··· 966 966 967 967 /* register adapter */ 968 968 result = dvb_register_adapter(&dvb->adapter, 969 - dev_name(&dev->udev->dev), module, 969 + dev_name(&dev->intf->dev), module, 970 970 device, adapter_nr); 971 971 if (result < 0) { 972 - dev_warn(&dev->udev->dev, 972 + dev_warn(&dev->intf->dev, 973 973 "dvb_register_adapter failed (errno = %d)\n", 974 974 result); 975 975 goto fail_adapter; ··· 988 988 /* register frontend */ 989 989 result = dvb_register_frontend(&dvb->adapter, dvb->fe[0]); 990 990 if (result < 0) { 991 - dev_warn(&dev->udev->dev, 991 + dev_warn(&dev->intf->dev, 992 992 "dvb_register_frontend failed (errno = %d)\n", 993 993 result); 994 994 goto fail_frontend0; ··· 998 998 if (dvb->fe[1]) { 999 999 result = dvb_register_frontend(&dvb->adapter, dvb->fe[1]); 1000 1000 if (result < 0) { 1001 - dev_warn(&dev->udev->dev, 1001 + dev_warn(&dev->intf->dev, 1002 1002 "2nd dvb_register_frontend failed (errno = %d)\n", 1003 1003 result); 1004 1004 goto fail_frontend1; ··· 1017 1017 1018 1018 result = dvb_dmx_init(&dvb->demux); 1019 1019 if (result < 0) { 1020 - dev_warn(&dev->udev->dev, 1020 + dev_warn(&dev->intf->dev, 1021 1021 "dvb_dmx_init failed (errno = %d)\n", 1022 1022 result); 1023 1023 goto fail_dmx; ··· 1028 1028 dvb->dmxdev.capabilities = 0; 1029 1029 result = dvb_dmxdev_init(&dvb->dmxdev, &dvb->adapter); 1030 1030 if (result < 0) { 1031 - dev_warn(&dev->udev->dev, 1031 + dev_warn(&dev->intf->dev, 1032 1032 "dvb_dmxdev_init failed (errno = %d)\n", 1033 1033 result); 1034 1034 goto fail_dmxdev; ··· 1037 1037 dvb->fe_hw.source = DMX_FRONTEND_0; 1038 1038 result = dvb->demux.dmx.add_frontend(&dvb->demux.dmx, &dvb->fe_hw); 1039 1039 if (result < 0) { 1040 - dev_warn(&dev->udev->dev, 1040 + dev_warn(&dev->intf->dev, 1041 1041 "add_frontend failed (DMX_FRONTEND_0, errno = %d)\n", 1042 1042 result); 1043 1043 goto fail_fe_hw; ··· 1046 1046 dvb->fe_mem.source = DMX_MEMORY_FE; 1047 1047 result = dvb->demux.dmx.add_frontend(&dvb->demux.dmx, &dvb->fe_mem); 1048 1048 if (result < 0) { 1049 - dev_warn(&dev->udev->dev, 1049 + dev_warn(&dev->intf->dev, 1050 1050 "add_frontend failed (DMX_MEMORY_FE, errno = %d)\n", 1051 1051 result); 1052 1052 goto fail_fe_mem; ··· 1054 1054 1055 1055 result = dvb->demux.dmx.connect_frontend(&dvb->demux.dmx, &dvb->fe_hw); 1056 1056 if (result < 0) { 1057 - dev_warn(&dev->udev->dev, 1057 + dev_warn(&dev->intf->dev, 1058 1058 "connect_frontend failed (errno = %d)\n", 1059 1059 result); 1060 1060 goto fail_fe_conn; ··· 1128 1128 return 0; 1129 1129 } 1130 1130 1131 - dev_info(&dev->udev->dev, "Binding DVB extension\n"); 1131 + dev_info(&dev->intf->dev, "Binding DVB extension\n"); 1132 1132 1133 1133 dvb = kzalloc(sizeof(struct em28xx_dvb), GFP_KERNEL); 1134 1134 if (!dvb) ··· 1152 1152 EM28XX_DVB_NUM_ISOC_PACKETS); 1153 1153 } 1154 1154 if (result) { 1155 - dev_err(&dev->udev->dev, 1155 + dev_err(&dev->intf->dev, 1156 1156 "failed to pre-allocate USB transfer buffers for DVB.\n"); 1157 1157 kfree(dvb); 1158 1158 dev->dvb = NULL; ··· 1270 1270 case EM2880_BOARD_HAUPPAUGE_WINTV_HVR_900_R2: 1271 1271 case EM2882_BOARD_PINNACLE_HYBRID_PRO_330E: 1272 1272 dvb->fe[0] = dvb_attach(drxd_attach, &em28xx_drxd, NULL, 1273 - &dev->i2c_adap[dev->def_i2c_bus], &dev->udev->dev); 1273 + &dev->i2c_adap[dev->def_i2c_bus], 1274 + &dev->intf->dev); 1274 1275 if (em28xx_attach_xc3028(0x61, dev) < 0) { 1275 1276 result = -EINVAL; 1276 1277 goto out_free; ··· 1333 1332 result = gpio_request_one(dvb->lna_gpio, 1334 1333 GPIOF_OUT_INIT_LOW, NULL); 1335 1334 if (result) 1336 - dev_err(&dev->udev->dev, 1335 + dev_err(&dev->intf->dev, 1337 1336 "gpio request failed %d\n", 1338 1337 result); 1339 1338 else ··· 1950 1949 } 1951 1950 break; 1952 1951 default: 1953 - dev_err(&dev->udev->dev, 1952 + dev_err(&dev->intf->dev, 1954 1953 "The frontend of your DVB/ATSC card isn't supported yet\n"); 1955 1954 break; 1956 1955 } 1957 1956 if (NULL == dvb->fe[0]) { 1958 - dev_err(&dev->udev->dev, "frontend initialization failed\n"); 1957 + dev_err(&dev->intf->dev, "frontend initialization failed\n"); 1959 1958 result = -EINVAL; 1960 1959 goto out_free; 1961 1960 } ··· 1965 1964 dvb->fe[1]->callback = em28xx_tuner_callback; 1966 1965 1967 1966 /* register everything */ 1968 - result = em28xx_register_dvb(dvb, THIS_MODULE, dev, &dev->udev->dev); 1967 + result = em28xx_register_dvb(dvb, THIS_MODULE, dev, &dev->intf->dev); 1969 1968 1970 1969 if (result < 0) 1971 1970 goto out_free; 1972 1971 1973 - dev_info(&dev->udev->dev, "DVB extension successfully initialized\n"); 1972 + dev_info(&dev->intf->dev, "DVB extension successfully initialized\n"); 1974 1973 1975 1974 kref_get(&dev->ref); 1976 1975 ··· 2010 2009 if (!dev->dvb) 2011 2010 return 0; 2012 2011 2013 - dev_info(&dev->udev->dev, "Closing DVB extension\n"); 2012 + dev_info(&dev->intf->dev, "Closing DVB extension\n"); 2014 2013 2015 2014 dvb = dev->dvb; 2016 2015 ··· 2068 2067 if (!dev->board.has_dvb) 2069 2068 return 0; 2070 2069 2071 - dev_info(&dev->udev->dev, "Suspending DVB extension\n"); 2070 + dev_info(&dev->intf->dev, "Suspending DVB extension\n"); 2072 2071 if (dev->dvb) { 2073 2072 struct em28xx_dvb *dvb = dev->dvb; 2074 2073 2075 2074 if (dvb->fe[0]) { 2076 2075 ret = dvb_frontend_suspend(dvb->fe[0]); 2077 - dev_info(&dev->udev->dev, "fe0 suspend %d\n", ret); 2076 + dev_info(&dev->intf->dev, "fe0 suspend %d\n", ret); 2078 2077 } 2079 2078 if (dvb->fe[1]) { 2080 2079 dvb_frontend_suspend(dvb->fe[1]); 2081 - dev_info(&dev->udev->dev, "fe1 suspend %d\n", ret); 2080 + dev_info(&dev->intf->dev, "fe1 suspend %d\n", ret); 2082 2081 } 2083 2082 } 2084 2083 ··· 2095 2094 if (!dev->board.has_dvb) 2096 2095 return 0; 2097 2096 2098 - dev_info(&dev->udev->dev, "Resuming DVB extension\n"); 2097 + dev_info(&dev->intf->dev, "Resuming DVB extension\n"); 2099 2098 if (dev->dvb) { 2100 2099 struct em28xx_dvb *dvb = dev->dvb; 2101 2100 2102 2101 if (dvb->fe[0]) { 2103 2102 ret = dvb_frontend_resume(dvb->fe[0]); 2104 - dev_info(&dev->udev->dev, "fe0 resume %d\n", ret); 2103 + dev_info(&dev->intf->dev, "fe0 resume %d\n", ret); 2105 2104 } 2106 2105 2107 2106 if (dvb->fe[1]) { 2108 2107 ret = dvb_frontend_resume(dvb->fe[1]); 2109 - dev_info(&dev->udev->dev, "fe1 resume %d\n", ret); 2108 + dev_info(&dev->intf->dev, "fe1 resume %d\n", ret); 2110 2109 } 2111 2110 } 2112 2111
+46 -46
drivers/media/usb/em28xx/em28xx-i2c.c
··· 46 46 47 47 #define dprintk(level, fmt, arg...) do { \ 48 48 if (i2c_debug > level) \ 49 - dev_printk(KERN_DEBUG, &dev->udev->dev, \ 49 + dev_printk(KERN_DEBUG, &dev->intf->dev, \ 50 50 "i2c: %s: " fmt, __func__, ## arg); \ 51 51 } while (0) 52 52 ··· 78 78 /* trigger write */ 79 79 ret = dev->em28xx_write_regs(dev, 4 - len, &b2[4 - len], 2 + len); 80 80 if (ret != 2 + len) { 81 - dev_warn(&dev->udev->dev, 81 + dev_warn(&dev->intf->dev, 82 82 "failed to trigger write to i2c address 0x%x (error=%i)\n", 83 83 addr, ret); 84 84 return (ret < 0) ? ret : -EIO; ··· 93 93 return -ENXIO; 94 94 } 95 95 if (ret < 0) { 96 - dev_warn(&dev->udev->dev, 96 + dev_warn(&dev->intf->dev, 97 97 "failed to get i2c transfer status from bridge register (error=%i)\n", 98 98 ret); 99 99 return ret; ··· 123 123 buf2[0] = addr; 124 124 ret = dev->em28xx_write_regs(dev, 0x04, buf2, 2); 125 125 if (ret != 2) { 126 - dev_warn(&dev->udev->dev, 126 + dev_warn(&dev->intf->dev, 127 127 "failed to trigger read from i2c address 0x%x (error=%i)\n", 128 128 addr, ret); 129 129 return (ret < 0) ? ret : -EIO; ··· 140 140 return -ENXIO; 141 141 } 142 142 if (ret < 0) { 143 - dev_warn(&dev->udev->dev, 143 + dev_warn(&dev->intf->dev, 144 144 "failed to get i2c transfer status from bridge register (error=%i)\n", 145 145 ret); 146 146 return ret; ··· 154 154 /* get the received message */ 155 155 ret = dev->em28xx_read_reg_req_len(dev, 0x00, 4-len, buf2, len); 156 156 if (ret != len) { 157 - dev_warn(&dev->udev->dev, 157 + dev_warn(&dev->intf->dev, 158 158 "reading from i2c device at 0x%x failed: couldn't get the received message from the bridge (error=%i)\n", 159 159 addr, ret); 160 160 return (ret < 0) ? ret : -EIO; ··· 200 200 ret = dev->em28xx_write_regs_req(dev, stop ? 2 : 3, addr, buf, len); 201 201 if (ret != len) { 202 202 if (ret < 0) { 203 - dev_warn(&dev->udev->dev, 203 + dev_warn(&dev->intf->dev, 204 204 "writing to i2c device at 0x%x failed (error=%i)\n", 205 205 addr, ret); 206 206 return ret; 207 207 } else { 208 - dev_warn(&dev->udev->dev, 208 + dev_warn(&dev->intf->dev, 209 209 "%i bytes write to i2c device at 0x%x requested, but %i bytes written\n", 210 210 len, addr, ret); 211 211 return -EIO; ··· 223 223 return -ENXIO; 224 224 } 225 225 if (ret < 0) { 226 - dev_warn(&dev->udev->dev, 226 + dev_warn(&dev->intf->dev, 227 227 "failed to get i2c transfer status from bridge register (error=%i)\n", 228 228 ret); 229 229 return ret; ··· 244 244 return -ETIMEDOUT; 245 245 } 246 246 247 - dev_warn(&dev->udev->dev, 247 + dev_warn(&dev->intf->dev, 248 248 "write to i2c device at 0x%x failed with unknown error (status=%i)\n", 249 249 addr, ret); 250 250 return -EIO; ··· 268 268 /* Read data from i2c device */ 269 269 ret = dev->em28xx_read_reg_req_len(dev, 2, addr, buf, len); 270 270 if (ret < 0) { 271 - dev_warn(&dev->udev->dev, 271 + dev_warn(&dev->intf->dev, 272 272 "reading from i2c device at 0x%x failed (error=%i)\n", 273 273 addr, ret); 274 274 return ret; ··· 287 287 if (ret == 0) /* success */ 288 288 return len; 289 289 if (ret < 0) { 290 - dev_warn(&dev->udev->dev, 290 + dev_warn(&dev->intf->dev, 291 291 "failed to get i2c transfer status from bridge register (error=%i)\n", 292 292 ret); 293 293 return ret; ··· 306 306 return -ETIMEDOUT; 307 307 } 308 308 309 - dev_warn(&dev->udev->dev, 309 + dev_warn(&dev->intf->dev, 310 310 "write to i2c device at 0x%x failed with unknown error (status=%i)\n", 311 311 addr, ret); 312 312 return -EIO; ··· 347 347 ret = dev->em28xx_write_regs_req(dev, 0x06, addr, buf, len); 348 348 if (ret != len) { 349 349 if (ret < 0) { 350 - dev_warn(&dev->udev->dev, 350 + dev_warn(&dev->intf->dev, 351 351 "writing to i2c device at 0x%x failed (error=%i)\n", 352 352 addr, ret); 353 353 return ret; 354 354 } else { 355 - dev_warn(&dev->udev->dev, 355 + dev_warn(&dev->intf->dev, 356 356 "%i bytes write to i2c device at 0x%x requested, but %i bytes written\n", 357 357 len, addr, ret); 358 358 return -EIO; ··· 398 398 /* Read value */ 399 399 ret = dev->em28xx_read_reg_req_len(dev, 0x06, addr, buf, len); 400 400 if (ret < 0) { 401 - dev_warn(&dev->udev->dev, 401 + dev_warn(&dev->intf->dev, 402 402 "reading from i2c device at 0x%x failed (error=%i)\n", 403 403 addr, ret); 404 404 return ret; ··· 672 672 /* Check if board has eeprom */ 673 673 err = i2c_master_recv(&dev->i2c_client[bus], &buf, 0); 674 674 if (err < 0) { 675 - dev_info(&dev->udev->dev, "board has no eeprom\n"); 675 + dev_info(&dev->intf->dev, "board has no eeprom\n"); 676 676 return -ENODEV; 677 677 } 678 678 ··· 685 685 dev->eeprom_addrwidth_16bit, 686 686 len, data); 687 687 if (err != len) { 688 - dev_err(&dev->udev->dev, 688 + dev_err(&dev->intf->dev, 689 689 "failed to read eeprom (err=%d)\n", err); 690 690 goto error; 691 691 } ··· 696 696 16, 1, data, len, true); 697 697 698 698 if (dev->eeprom_addrwidth_16bit) 699 - dev_info(&dev->udev->dev, 699 + dev_info(&dev->intf->dev, 700 700 "eeprom %06x: ... (skipped)\n", 256); 701 701 } 702 702 ··· 709 709 dev->hash = em28xx_hash_mem(data, len, 32); 710 710 mc_start = (data[1] << 8) + 4; /* usually 0x0004 */ 711 711 712 - dev_info(&dev->udev->dev, 712 + dev_info(&dev->intf->dev, 713 713 "EEPROM ID = %02x %02x %02x %02x, EEPROM hash = 0x%08lx\n", 714 714 data[0], data[1], data[2], data[3], dev->hash); 715 - dev_info(&dev->udev->dev, 715 + dev_info(&dev->intf->dev, 716 716 "EEPROM info:\n"); 717 - dev_info(&dev->udev->dev, 717 + dev_info(&dev->intf->dev, 718 718 "\tmicrocode start address = 0x%04x, boot configuration = 0x%02x\n", 719 719 mc_start, data[2]); 720 720 /* ··· 734 734 err = em28xx_i2c_read_block(dev, bus, mc_start + 46, 1, 2, 735 735 data); 736 736 if (err != 2) { 737 - dev_err(&dev->udev->dev, 737 + dev_err(&dev->intf->dev, 738 738 "failed to read hardware configuration data from eeprom (err=%d)\n", 739 739 err); 740 740 goto error; ··· 753 753 err = em28xx_i2c_read_block(dev, bus, hwconf_offset, 1, len, 754 754 data); 755 755 if (err != len) { 756 - dev_err(&dev->udev->dev, 756 + dev_err(&dev->intf->dev, 757 757 "failed to read hardware configuration data from eeprom (err=%d)\n", 758 758 err); 759 759 goto error; ··· 763 763 /* NOTE: not all devices provide this type of dataset */ 764 764 if (data[0] != 0x1a || data[1] != 0xeb || 765 765 data[2] != 0x67 || data[3] != 0x95) { 766 - dev_info(&dev->udev->dev, 766 + dev_info(&dev->intf->dev, 767 767 "\tno hardware configuration dataset found in eeprom\n"); 768 768 kfree(data); 769 769 return 0; ··· 775 775 data[0] == 0x1a && data[1] == 0xeb && 776 776 data[2] == 0x67 && data[3] == 0x95) { 777 777 dev->hash = em28xx_hash_mem(data, len, 32); 778 - dev_info(&dev->udev->dev, 778 + dev_info(&dev->intf->dev, 779 779 "EEPROM ID = %02x %02x %02x %02x, EEPROM hash = 0x%08lx\n", 780 780 data[0], data[1], data[2], data[3], dev->hash); 781 - dev_info(&dev->udev->dev, 781 + dev_info(&dev->intf->dev, 782 782 "EEPROM info:\n"); 783 783 } else { 784 - dev_info(&dev->udev->dev, 784 + dev_info(&dev->intf->dev, 785 785 "unknown eeprom format or eeprom corrupted !\n"); 786 786 err = -ENODEV; 787 787 goto error; ··· 793 793 794 794 switch (le16_to_cpu(dev_config->chip_conf) >> 4 & 0x3) { 795 795 case 0: 796 - dev_info(&dev->udev->dev, "\tNo audio on board.\n"); 796 + dev_info(&dev->intf->dev, "\tNo audio on board.\n"); 797 797 break; 798 798 case 1: 799 - dev_info(&dev->udev->dev, "\tAC97 audio (5 sample rates)\n"); 799 + dev_info(&dev->intf->dev, "\tAC97 audio (5 sample rates)\n"); 800 800 break; 801 801 case 2: 802 802 if (dev->chip_id < CHIP_ID_EM2860) 803 - dev_info(&dev->udev->dev, 803 + dev_info(&dev->intf->dev, 804 804 "\tI2S audio, sample rate=32k\n"); 805 805 else 806 - dev_info(&dev->udev->dev, 806 + dev_info(&dev->intf->dev, 807 807 "\tI2S audio, 3 sample rates\n"); 808 808 break; 809 809 case 3: 810 810 if (dev->chip_id < CHIP_ID_EM2860) 811 - dev_info(&dev->udev->dev, 811 + dev_info(&dev->intf->dev, 812 812 "\tI2S audio, 3 sample rates\n"); 813 813 else 814 - dev_info(&dev->udev->dev, 814 + dev_info(&dev->intf->dev, 815 815 "\tI2S audio, 5 sample rates\n"); 816 816 break; 817 817 } 818 818 819 819 if (le16_to_cpu(dev_config->chip_conf) & 1 << 3) 820 - dev_info(&dev->udev->dev, "\tUSB Remote wakeup capable\n"); 820 + dev_info(&dev->intf->dev, "\tUSB Remote wakeup capable\n"); 821 821 822 822 if (le16_to_cpu(dev_config->chip_conf) & 1 << 2) 823 - dev_info(&dev->udev->dev, "\tUSB Self power capable\n"); 823 + dev_info(&dev->intf->dev, "\tUSB Self power capable\n"); 824 824 825 825 switch (le16_to_cpu(dev_config->chip_conf) & 0x3) { 826 826 case 0: 827 - dev_info(&dev->udev->dev, "\t500mA max power\n"); 827 + dev_info(&dev->intf->dev, "\t500mA max power\n"); 828 828 break; 829 829 case 1: 830 - dev_info(&dev->udev->dev, "\t400mA max power\n"); 830 + dev_info(&dev->intf->dev, "\t400mA max power\n"); 831 831 break; 832 832 case 2: 833 - dev_info(&dev->udev->dev, "\t300mA max power\n"); 833 + dev_info(&dev->intf->dev, "\t300mA max power\n"); 834 834 break; 835 835 case 3: 836 - dev_info(&dev->udev->dev, "\t200mA max power\n"); 836 + dev_info(&dev->intf->dev, "\t200mA max power\n"); 837 837 break; 838 838 } 839 - dev_info(&dev->udev->dev, 839 + dev_info(&dev->intf->dev, 840 840 "\tTable at offset 0x%02x, strings=0x%04x, 0x%04x, 0x%04x\n", 841 841 dev_config->string_idx_table, 842 842 le16_to_cpu(dev_config->string1), ··· 930 930 if (rc < 0) 931 931 continue; 932 932 i2c_devicelist[i] = i; 933 - dev_info(&dev->udev->dev, 933 + dev_info(&dev->intf->dev, 934 934 "found i2c device @ 0x%x on bus %d [%s]\n", 935 935 i << 1, bus, i2c_devs[i] ? i2c_devs[i] : "???"); 936 936 } ··· 956 956 return -ENODEV; 957 957 958 958 dev->i2c_adap[bus] = em28xx_adap_template; 959 - dev->i2c_adap[bus].dev.parent = &dev->udev->dev; 960 - strcpy(dev->i2c_adap[bus].name, dev_name(&dev->udev->dev)); 959 + dev->i2c_adap[bus].dev.parent = &dev->intf->dev; 960 + strcpy(dev->i2c_adap[bus].name, dev_name(&dev->intf->dev)); 961 961 962 962 dev->i2c_bus[bus].bus = bus; 963 963 dev->i2c_bus[bus].algo_type = algo_type; ··· 966 966 967 967 retval = i2c_add_adapter(&dev->i2c_adap[bus]); 968 968 if (retval < 0) { 969 - dev_err(&dev->udev->dev, 969 + dev_err(&dev->intf->dev, 970 970 "%s: i2c_add_adapter failed! retval [%d]\n", 971 971 __func__, retval); 972 972 return retval; ··· 979 979 if (!bus) { 980 980 retval = em28xx_i2c_eeprom(dev, bus, &dev->eedata, &dev->eedata_len); 981 981 if ((retval < 0) && (retval != -ENODEV)) { 982 - dev_err(&dev->udev->dev, 982 + dev_err(&dev->intf->dev, 983 983 "%s: em28xx_i2_eeprom failed! retval [%d]\n", 984 984 __func__, retval); 985 985
+16 -16
drivers/media/usb/em28xx/em28xx-input.c
··· 43 43 44 44 #define dprintk( fmt, arg...) do { \ 45 45 if (ir_debug) \ 46 - dev_printk(KERN_DEBUG, &ir->dev->udev->dev, \ 46 + dev_printk(KERN_DEBUG, &ir->dev->intf->dev, \ 47 47 "input: %s: " fmt, __func__, ## arg); \ 48 48 } while (0) 49 49 ··· 459 459 case CHIP_ID_EM28178: 460 460 return em2874_ir_change_protocol(rc_dev, rc_type); 461 461 default: 462 - dev_err(&ir->dev->udev->dev, 462 + dev_err(&ir->dev->intf->dev, 463 463 "Unrecognized em28xx chip id 0x%02x: IR not supported\n", 464 464 dev->chip_id); 465 465 return -EINVAL; ··· 569 569 struct input_dev *input_dev; 570 570 int err; 571 571 572 - dev_info(&dev->udev->dev, "Registering snapshot button...\n"); 572 + dev_info(&dev->intf->dev, "Registering snapshot button...\n"); 573 573 input_dev = input_allocate_device(); 574 574 if (!input_dev) 575 575 return -ENOMEM; ··· 589 589 input_dev->id.vendor = le16_to_cpu(dev->udev->descriptor.idVendor); 590 590 input_dev->id.product = le16_to_cpu(dev->udev->descriptor.idProduct); 591 591 input_dev->id.version = 1; 592 - input_dev->dev.parent = &dev->udev->dev; 592 + input_dev->dev.parent = &dev->intf->dev; 593 593 594 594 err = input_register_device(input_dev); 595 595 if (err) { 596 - dev_err(&dev->udev->dev, "input_register_device failed\n"); 596 + dev_err(&dev->intf->dev, "input_register_device failed\n"); 597 597 input_free_device(input_dev); 598 598 return err; 599 599 } ··· 633 633 } else if (button->role == EM28XX_BUTTON_ILLUMINATION) { 634 634 /* Check sanity */ 635 635 if (!em28xx_find_led(dev, EM28XX_LED_ILLUMINATION)) { 636 - dev_err(&dev->udev->dev, 636 + dev_err(&dev->intf->dev, 637 637 "BUG: illumination button defined, but no illumination LED.\n"); 638 638 goto next_button; 639 639 } ··· 670 670 dev->num_button_polling_addresses = 0; 671 671 /* Deregister input devices */ 672 672 if (dev->sbutton_input_dev != NULL) { 673 - dev_info(&dev->udev->dev, "Deregistering snapshot button\n"); 673 + dev_info(&dev->intf->dev, "Deregistering snapshot button\n"); 674 674 input_unregister_device(dev->sbutton_input_dev); 675 675 dev->sbutton_input_dev = NULL; 676 676 } ··· 699 699 i2c_rc_dev_addr = em28xx_probe_i2c_ir(dev); 700 700 if (!i2c_rc_dev_addr) { 701 701 dev->board.has_ir_i2c = 0; 702 - dev_warn(&dev->udev->dev, 702 + dev_warn(&dev->intf->dev, 703 703 "No i2c IR remote control device found.\n"); 704 704 return -ENODEV; 705 705 } ··· 707 707 708 708 if (dev->board.ir_codes == NULL && !dev->board.has_ir_i2c) { 709 709 /* No remote control support */ 710 - dev_warn(&dev->udev->dev, 710 + dev_warn(&dev->intf->dev, 711 711 "Remote control support is not available for this card.\n"); 712 712 return 0; 713 713 } 714 714 715 - dev_info(&dev->udev->dev, "Registering input extension\n"); 715 + dev_info(&dev->intf->dev, "Registering input extension\n"); 716 716 717 717 ir = kzalloc(sizeof(*ir), GFP_KERNEL); 718 718 if (!ir) ··· 797 797 798 798 /* init input device */ 799 799 snprintf(ir->name, sizeof(ir->name), "%s IR", 800 - dev_name(&dev->udev->dev)); 800 + dev_name(&dev->intf->dev)); 801 801 802 802 usb_make_path(dev->udev, ir->phys, sizeof(ir->phys)); 803 803 strlcat(ir->phys, "/input0", sizeof(ir->phys)); ··· 808 808 rc->input_id.version = 1; 809 809 rc->input_id.vendor = le16_to_cpu(dev->udev->descriptor.idVendor); 810 810 rc->input_id.product = le16_to_cpu(dev->udev->descriptor.idProduct); 811 - rc->dev.parent = &dev->udev->dev; 811 + rc->dev.parent = &dev->intf->dev; 812 812 rc->driver_name = MODULE_NAME; 813 813 814 814 /* all done */ ··· 816 816 if (err) 817 817 goto error; 818 818 819 - dev_info(&dev->udev->dev, "Input extension successfully initalized\n"); 819 + dev_info(&dev->intf->dev, "Input extension successfully initalized\n"); 820 820 821 821 return 0; 822 822 ··· 837 837 return 0; 838 838 } 839 839 840 - dev_info(&dev->udev->dev, "Closing input extension\n"); 840 + dev_info(&dev->intf->dev, "Closing input extension\n"); 841 841 842 842 em28xx_shutdown_buttons(dev); 843 843 ··· 866 866 if (dev->is_audio_only) 867 867 return 0; 868 868 869 - dev_info(&dev->udev->dev, "Suspending input extension\n"); 869 + dev_info(&dev->intf->dev, "Suspending input extension\n"); 870 870 if (ir) 871 871 cancel_delayed_work_sync(&ir->work); 872 872 cancel_delayed_work_sync(&dev->buttons_query_work); ··· 883 883 if (dev->is_audio_only) 884 884 return 0; 885 885 886 - dev_info(&dev->udev->dev, "Resuming input extension\n"); 886 + dev_info(&dev->intf->dev, "Resuming input extension\n"); 887 887 /* if suspend calls ir_raw_event_unregister(), the should call 888 888 ir_raw_event_register() */ 889 889 if (ir)
+1 -1
drivers/media/usb/em28xx/em28xx-vbi.c
··· 65 65 size = v4l2->vbi_width * v4l2->vbi_height * 2; 66 66 67 67 if (vb2_plane_size(vb, 0) < size) { 68 - dev_info(&dev->udev->dev, 68 + dev_info(&dev->intf->dev, 69 69 "%s data will not fit into plane (%lu < %lu)\n", 70 70 __func__, vb2_plane_size(vb, 0), size); 71 71 return -EINVAL;
+34 -34
drivers/media/usb/em28xx/em28xx-video.c
··· 66 66 67 67 #define em28xx_videodbg(fmt, arg...) do { \ 68 68 if (video_debug) \ 69 - dev_printk(KERN_DEBUG, &dev->udev->dev, \ 69 + dev_printk(KERN_DEBUG, &dev->intf->dev, \ 70 70 "video: %s: " fmt, __func__, ## arg); \ 71 71 } while (0) 72 72 73 73 #define em28xx_isocdbg(fmt, arg...) do {\ 74 74 if (isoc_debug) \ 75 - dev_printk(KERN_DEBUG, &dev->udev->dev, \ 75 + dev_printk(KERN_DEBUG, &dev->intf->dev, \ 76 76 "isoc: %s: " fmt, __func__, ## arg); \ 77 77 } while (0) 78 78 ··· 413 413 dev->alt, dev->max_pkt_size); 414 414 errCode = usb_set_interface(dev->udev, dev->ifnum, dev->alt); 415 415 if (errCode < 0) { 416 - dev_err(&dev->udev->dev, 416 + dev_err(&dev->intf->dev, 417 417 "cannot change alternate number to %d (error=%i)\n", 418 418 dev->alt, errCode); 419 419 return errCode; ··· 926 926 927 927 ret = media_entity_setup_link(link, flags); 928 928 if (ret) { 929 - dev_err(&dev->udev->dev, 929 + dev_err(&dev->intf->dev, 930 930 "Couldn't change link %s->%s to %s. Error %d\n", 931 931 source->name, sink->name, 932 932 flags ? "enabled" : "disabled", ··· 958 958 v4l2->video_pad.flags = MEDIA_PAD_FL_SINK; 959 959 ret = media_entity_pads_init(&v4l2->vdev.entity, 1, &v4l2->video_pad); 960 960 if (ret < 0) 961 - dev_err(&dev->udev->dev, 961 + dev_err(&dev->intf->dev, 962 962 "failed to initialize video media entity!\n"); 963 963 964 964 if (em28xx_vbi_supported(dev)) { ··· 966 966 ret = media_entity_pads_init(&v4l2->vbi_dev.entity, 1, 967 967 &v4l2->vbi_pad); 968 968 if (ret < 0) 969 - dev_err(&dev->udev->dev, 969 + dev_err(&dev->intf->dev, 970 970 "failed to initialize vbi media entity!\n"); 971 971 } 972 972 ··· 1000 1000 1001 1001 ret = media_entity_pads_init(ent, 1, &dev->input_pad[i]); 1002 1002 if (ret < 0) 1003 - dev_err(&dev->udev->dev, 1003 + dev_err(&dev->intf->dev, 1004 1004 "failed to initialize input pad[%d]!\n", i); 1005 1005 1006 1006 ret = media_device_register_entity(dev->media_dev, ent); 1007 1007 if (ret < 0) 1008 - dev_err(&dev->udev->dev, 1008 + dev_err(&dev->intf->dev, 1009 1009 "failed to register input entity %d!\n", i); 1010 1010 } 1011 1011 #endif ··· 2053 2053 2054 2054 ret = v4l2_fh_open(filp); 2055 2055 if (ret) { 2056 - dev_err(&dev->udev->dev, 2056 + dev_err(&dev->intf->dev, 2057 2057 "%s: v4l2_fh_open() returned error %d\n", 2058 2058 __func__, ret); 2059 2059 mutex_unlock(&dev->lock); ··· 2109 2109 if (v4l2 == NULL) 2110 2110 return 0; 2111 2111 2112 - dev_info(&dev->udev->dev, "Closing video extension\n"); 2112 + dev_info(&dev->intf->dev, "Closing video extension\n"); 2113 2113 2114 2114 mutex_lock(&dev->lock); 2115 2115 ··· 2120 2120 em28xx_v4l2_media_release(dev); 2121 2121 2122 2122 if (video_is_registered(&v4l2->radio_dev)) { 2123 - dev_info(&dev->udev->dev, "V4L2 device %s deregistered\n", 2123 + dev_info(&dev->intf->dev, "V4L2 device %s deregistered\n", 2124 2124 video_device_node_name(&v4l2->radio_dev)); 2125 2125 video_unregister_device(&v4l2->radio_dev); 2126 2126 } 2127 2127 if (video_is_registered(&v4l2->vbi_dev)) { 2128 - dev_info(&dev->udev->dev, "V4L2 device %s deregistered\n", 2128 + dev_info(&dev->intf->dev, "V4L2 device %s deregistered\n", 2129 2129 video_device_node_name(&v4l2->vbi_dev)); 2130 2130 video_unregister_device(&v4l2->vbi_dev); 2131 2131 } 2132 2132 if (video_is_registered(&v4l2->vdev)) { 2133 - dev_info(&dev->udev->dev, "V4L2 device %s deregistered\n", 2133 + dev_info(&dev->intf->dev, "V4L2 device %s deregistered\n", 2134 2134 video_device_node_name(&v4l2->vdev)); 2135 2135 video_unregister_device(&v4l2->vdev); 2136 2136 } ··· 2160 2160 if (!dev->has_video) 2161 2161 return 0; 2162 2162 2163 - dev_info(&dev->udev->dev, "Suspending video extension\n"); 2163 + dev_info(&dev->intf->dev, "Suspending video extension\n"); 2164 2164 em28xx_stop_urbs(dev); 2165 2165 return 0; 2166 2166 } ··· 2173 2173 if (!dev->has_video) 2174 2174 return 0; 2175 2175 2176 - dev_info(&dev->udev->dev, "Resuming video extension\n"); 2176 + dev_info(&dev->intf->dev, "Resuming video extension\n"); 2177 2177 /* what do we do here */ 2178 2178 return 0; 2179 2179 } ··· 2210 2210 em28xx_videodbg("setting alternate 0\n"); 2211 2211 errCode = usb_set_interface(dev->udev, 0, 0); 2212 2212 if (errCode < 0) { 2213 - dev_err(&dev->udev->dev, 2213 + dev_err(&dev->intf->dev, 2214 2214 "cannot change alternate number to 0 (error=%i)\n", 2215 2215 errCode); 2216 2216 } ··· 2345 2345 vfd->tvnorms = 0; 2346 2346 2347 2347 snprintf(vfd->name, sizeof(vfd->name), "%s %s", 2348 - dev_name(&dev->udev->dev), type_name); 2348 + dev_name(&dev->intf->dev), type_name); 2349 2349 2350 2350 video_set_drvdata(vfd, dev); 2351 2351 } ··· 2429 2429 return 0; 2430 2430 } 2431 2431 2432 - dev_info(&dev->udev->dev, "Registering V4L2 extension\n"); 2432 + dev_info(&dev->intf->dev, "Registering V4L2 extension\n"); 2433 2433 2434 2434 mutex_lock(&dev->lock); 2435 2435 ··· 2445 2445 #ifdef CONFIG_MEDIA_CONTROLLER 2446 2446 v4l2->v4l2_dev.mdev = dev->media_dev; 2447 2447 #endif 2448 - ret = v4l2_device_register(&dev->udev->dev, &v4l2->v4l2_dev); 2448 + ret = v4l2_device_register(&dev->intf->dev, &v4l2->v4l2_dev); 2449 2449 if (ret < 0) { 2450 - dev_err(&dev->udev->dev, 2450 + dev_err(&dev->intf->dev, 2451 2451 "Call to v4l2_device_register() failed!\n"); 2452 2452 goto err; 2453 2453 } ··· 2532 2532 /* Configure audio */ 2533 2533 ret = em28xx_audio_setup(dev); 2534 2534 if (ret < 0) { 2535 - dev_err(&dev->udev->dev, 2535 + dev_err(&dev->intf->dev, 2536 2536 "%s: Error while setting audio - error [%d]!\n", 2537 2537 __func__, ret); 2538 2538 goto unregister_dev; ··· 2561 2561 /* Send a reset to other chips via gpio */ 2562 2562 ret = em28xx_write_reg(dev, EM2820_R08_GPIO_CTRL, 0xf7); 2563 2563 if (ret < 0) { 2564 - dev_err(&dev->udev->dev, 2564 + dev_err(&dev->intf->dev, 2565 2565 "%s: em28xx_write_reg - msp34xx(1) failed! error [%d]\n", 2566 2566 __func__, ret); 2567 2567 goto unregister_dev; ··· 2570 2570 2571 2571 ret = em28xx_write_reg(dev, EM2820_R08_GPIO_CTRL, 0xff); 2572 2572 if (ret < 0) { 2573 - dev_err(&dev->udev->dev, 2573 + dev_err(&dev->intf->dev, 2574 2574 "%s: em28xx_write_reg - msp34xx(2) failed! error [%d]\n", 2575 2575 __func__, ret); 2576 2576 goto unregister_dev; ··· 2673 2673 ret = video_register_device(&v4l2->vdev, VFL_TYPE_GRABBER, 2674 2674 video_nr[dev->devno]); 2675 2675 if (ret) { 2676 - dev_err(&dev->udev->dev, 2676 + dev_err(&dev->intf->dev, 2677 2677 "unable to register video device (error=%i).\n", ret); 2678 2678 goto unregister_dev; 2679 2679 } ··· 2703 2703 ret = video_register_device(&v4l2->vbi_dev, VFL_TYPE_VBI, 2704 2704 vbi_nr[dev->devno]); 2705 2705 if (ret < 0) { 2706 - dev_err(&dev->udev->dev, 2706 + dev_err(&dev->intf->dev, 2707 2707 "unable to register vbi device\n"); 2708 2708 goto unregister_dev; 2709 2709 } ··· 2715 2715 ret = video_register_device(&v4l2->radio_dev, VFL_TYPE_RADIO, 2716 2716 radio_nr[dev->devno]); 2717 2717 if (ret < 0) { 2718 - dev_err(&dev->udev->dev, 2718 + dev_err(&dev->intf->dev, 2719 2719 "can't register radio device\n"); 2720 2720 goto unregister_dev; 2721 2721 } 2722 - dev_info(&dev->udev->dev, 2722 + dev_info(&dev->intf->dev, 2723 2723 "Registered radio device as %s\n", 2724 2724 video_device_node_name(&v4l2->radio_dev)); 2725 2725 } ··· 2730 2730 #ifdef CONFIG_MEDIA_CONTROLLER 2731 2731 ret = v4l2_mc_create_media_graph(dev->media_dev); 2732 2732 if (ret) { 2733 - dev_err(&dev->udev->dev, 2733 + dev_err(&dev->intf->dev, 2734 2734 "failed to create media graph\n"); 2735 2735 em28xx_v4l2_media_release(dev); 2736 2736 goto unregister_dev; 2737 2737 } 2738 2738 #endif 2739 2739 2740 - dev_info(&dev->udev->dev, 2740 + dev_info(&dev->intf->dev, 2741 2741 "V4L2 video device registered as %s\n", 2742 2742 video_device_node_name(&v4l2->vdev)); 2743 2743 2744 2744 if (video_is_registered(&v4l2->vbi_dev)) 2745 - dev_info(&dev->udev->dev, 2745 + dev_info(&dev->intf->dev, 2746 2746 "V4L2 VBI device registered as %s\n", 2747 2747 video_device_node_name(&v4l2->vbi_dev)); 2748 2748 ··· 2752 2752 /* initialize videobuf2 stuff */ 2753 2753 em28xx_vb2_setup(dev); 2754 2754 2755 - dev_info(&dev->udev->dev, 2755 + dev_info(&dev->intf->dev, 2756 2756 "V4L2 extension successfully initialized\n"); 2757 2757 2758 2758 kref_get(&dev->ref); ··· 2762 2762 2763 2763 unregister_dev: 2764 2764 if (video_is_registered(&v4l2->radio_dev)) { 2765 - dev_info(&dev->udev->dev, 2765 + dev_info(&dev->intf->dev, 2766 2766 "V4L2 device %s deregistered\n", 2767 2767 video_device_node_name(&v4l2->radio_dev)); 2768 2768 video_unregister_device(&v4l2->radio_dev); 2769 2769 } 2770 2770 if (video_is_registered(&v4l2->vbi_dev)) { 2771 - dev_info(&dev->udev->dev, 2771 + dev_info(&dev->intf->dev, 2772 2772 "V4L2 device %s deregistered\n", 2773 2773 video_device_node_name(&v4l2->vbi_dev)); 2774 2774 video_unregister_device(&v4l2->vbi_dev); 2775 2775 } 2776 2776 if (video_is_registered(&v4l2->vdev)) { 2777 - dev_info(&dev->udev->dev, 2777 + dev_info(&dev->intf->dev, 2778 2778 "V4L2 device %s deregistered\n", 2779 2779 video_device_node_name(&v4l2->vdev)); 2780 2780 video_unregister_device(&v4l2->vdev);
+1
drivers/media/usb/em28xx/em28xx.h
··· 678 678 679 679 /* usb transfer */ 680 680 struct usb_device *udev; /* the usb device */ 681 + struct usb_interface *intf; /* the usb interface */ 681 682 u8 ifnum; /* number of the assigned usb interface */ 682 683 u8 analog_ep_isoc; /* address of isoc endpoint for analog */ 683 684 u8 analog_ep_bulk; /* address of bulk endpoint for analog */