Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dpaa_eth: fix error return code in dpaa_eth_probe()

Fix to return a negative error code from the dpaa_bp_alloc() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Wei Yongjun and committed by
David S. Miller
29130853 c221fe40

+3 -3
+3 -3
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
··· 2728 2728 2729 2729 /* bp init */ 2730 2730 for (i = 0; i < DPAA_BPS_NUM; i++) { 2731 - int err; 2732 - 2733 2731 dpaa_bps[i] = dpaa_bp_alloc(dev); 2734 - if (IS_ERR(dpaa_bps[i])) 2732 + if (IS_ERR(dpaa_bps[i])) { 2733 + err = PTR_ERR(dpaa_bps[i]); 2735 2734 goto free_dpaa_bps; 2735 + } 2736 2736 /* the raw size of the buffers used for reception */ 2737 2737 dpaa_bps[i]->raw_size = bpool_buffer_raw_size(i, DPAA_BPS_NUM); 2738 2738 /* avoid runtime computations by keeping the usable size here */