Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pch_uart: drop double zeroing

sg_init_table zeroes its first argument, so the allocation of that argument
doesn't have to.

the semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,n,flags;
@@

x =
- kcalloc
+ kmalloc_array
(n,sizeof(struct scatterlist),flags)
...
sg_init_table(x,n)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

Link: https://lore.kernel.org/r/1600601186-7420-2-git-send-email-Julia.Lawall@inria.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Julia Lawall and committed by
Greg Kroah-Hartman
290ff182 7d2bfdf1

+1 -1
+1 -1
drivers/tty/serial/pch_uart.c
··· 981 981 982 982 priv->tx_dma_use = 1; 983 983 984 - priv->sg_tx_p = kcalloc(num, sizeof(struct scatterlist), GFP_ATOMIC); 984 + priv->sg_tx_p = kmalloc_array(num, sizeof(struct scatterlist), GFP_ATOMIC); 985 985 if (!priv->sg_tx_p) { 986 986 dev_err(priv->port.dev, "%s:kzalloc Failed\n", __func__); 987 987 return 0;