Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/imx: consolidate bus format variable names

This patch consolidates the different interface_pix_fmt, pixel_fmt, pix_fmt,
and pixfmt variables to a common name "bus_format" wherever they describe the
pixel format on the bus between display controller and encoder hardware.
At the same time, it renames imx_drm_panel_format to imx_drm_set_bus_format.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Tested-by: Emil Renner Berthing <kernel@esmil.dk>

+35 -39
+1 -1
drivers/gpu/drm/imx/dw_hdmi-imx.c
··· 123 123 124 124 static void dw_hdmi_imx_encoder_prepare(struct drm_encoder *encoder) 125 125 { 126 - imx_drm_panel_format(encoder, MEDIA_BUS_FMT_RGB888_1X24); 126 + imx_drm_set_bus_format(encoder, MEDIA_BUS_FMT_RGB888_1X24); 127 127 } 128 128 129 129 static struct drm_encoder_helper_funcs dw_hdmi_imx_encoder_helper_funcs = {
+7 -7
drivers/gpu/drm/imx/imx-drm-core.c
··· 103 103 return NULL; 104 104 } 105 105 106 - int imx_drm_panel_format_pins(struct drm_encoder *encoder, 107 - u32 interface_pix_fmt, int hsync_pin, int vsync_pin) 106 + int imx_drm_set_bus_format_pins(struct drm_encoder *encoder, u32 bus_format, 107 + int hsync_pin, int vsync_pin) 108 108 { 109 109 struct imx_drm_crtc_helper_funcs *helper; 110 110 struct imx_drm_crtc *imx_crtc; ··· 116 116 helper = &imx_crtc->imx_drm_helper_funcs; 117 117 if (helper->set_interface_pix_fmt) 118 118 return helper->set_interface_pix_fmt(encoder->crtc, 119 - interface_pix_fmt, hsync_pin, vsync_pin); 119 + bus_format, hsync_pin, vsync_pin); 120 120 return 0; 121 121 } 122 - EXPORT_SYMBOL_GPL(imx_drm_panel_format_pins); 122 + EXPORT_SYMBOL_GPL(imx_drm_set_bus_format_pins); 123 123 124 - int imx_drm_panel_format(struct drm_encoder *encoder, u32 interface_pix_fmt) 124 + int imx_drm_set_bus_format(struct drm_encoder *encoder, u32 bus_format) 125 125 { 126 - return imx_drm_panel_format_pins(encoder, interface_pix_fmt, 2, 3); 126 + return imx_drm_set_bus_format_pins(encoder, bus_format, 2, 3); 127 127 } 128 - EXPORT_SYMBOL_GPL(imx_drm_panel_format); 128 + EXPORT_SYMBOL_GPL(imx_drm_set_bus_format); 129 129 130 130 int imx_drm_crtc_vblank_get(struct imx_drm_crtc *imx_drm_crtc) 131 131 {
+5 -5
drivers/gpu/drm/imx/imx-drm.h
··· 18 18 int (*enable_vblank)(struct drm_crtc *crtc); 19 19 void (*disable_vblank)(struct drm_crtc *crtc); 20 20 int (*set_interface_pix_fmt)(struct drm_crtc *crtc, 21 - u32 pix_fmt, int hsync_pin, int vsync_pin); 21 + u32 bus_format, int hsync_pin, int vsync_pin); 22 22 const struct drm_crtc_helper_funcs *crtc_helper_funcs; 23 23 const struct drm_crtc_funcs *crtc_funcs; 24 24 }; ··· 40 40 41 41 struct drm_gem_cma_object *imx_drm_fb_get_obj(struct drm_framebuffer *fb); 42 42 43 - int imx_drm_panel_format_pins(struct drm_encoder *encoder, 44 - u32 interface_pix_fmt, int hsync_pin, int vsync_pin); 45 - int imx_drm_panel_format(struct drm_encoder *encoder, 46 - u32 interface_pix_fmt); 43 + int imx_drm_set_bus_format_pins(struct drm_encoder *encoder, 44 + u32 bus_format, int hsync_pin, int vsync_pin); 45 + int imx_drm_set_bus_format(struct drm_encoder *encoder, 46 + u32 bus_format); 47 47 48 48 int imx_drm_encoder_get_mux_id(struct device_node *node, 49 49 struct drm_encoder *encoder);
+5 -5
drivers/gpu/drm/imx/imx-ldb.c
··· 163 163 { 164 164 struct imx_ldb_channel *imx_ldb_ch = enc_to_imx_ldb_ch(encoder); 165 165 struct imx_ldb *ldb = imx_ldb_ch->ldb; 166 - u32 pixel_fmt; 166 + u32 bus_format; 167 167 168 168 switch (imx_ldb_ch->chno) { 169 169 case 0: 170 - pixel_fmt = (ldb->ldb_ctrl & LDB_DATA_WIDTH_CH0_24) ? 170 + bus_format = (ldb->ldb_ctrl & LDB_DATA_WIDTH_CH0_24) ? 171 171 MEDIA_BUS_FMT_RGB888_1X24 : MEDIA_BUS_FMT_RGB666_1X18; 172 172 break; 173 173 case 1: 174 - pixel_fmt = (ldb->ldb_ctrl & LDB_DATA_WIDTH_CH1_24) ? 174 + bus_format = (ldb->ldb_ctrl & LDB_DATA_WIDTH_CH1_24) ? 175 175 MEDIA_BUS_FMT_RGB888_1X24 : MEDIA_BUS_FMT_RGB666_1X18; 176 176 break; 177 177 default: 178 178 dev_err(ldb->dev, "unable to config di%d panel format\n", 179 179 imx_ldb_ch->chno); 180 - pixel_fmt = MEDIA_BUS_FMT_RGB888_1X24; 180 + bus_format = MEDIA_BUS_FMT_RGB888_1X24; 181 181 } 182 182 183 - imx_drm_panel_format(encoder, pixel_fmt); 183 + imx_drm_set_bus_format(encoder, bus_format); 184 184 } 185 185 186 186 static void imx_ldb_encoder_commit(struct drm_encoder *encoder)
+3 -3
drivers/gpu/drm/imx/imx-tve.c
··· 301 301 302 302 switch (tve->mode) { 303 303 case TVE_MODE_VGA: 304 - imx_drm_panel_format_pins(encoder, MEDIA_BUS_FMT_YUV8_1X24, 305 - tve->hsync_pin, tve->vsync_pin); 304 + imx_drm_set_bus_format_pins(encoder, MEDIA_BUS_FMT_YUV8_1X24, 305 + tve->hsync_pin, tve->vsync_pin); 306 306 break; 307 307 case TVE_MODE_TVOUT: 308 - imx_drm_panel_format(encoder, MEDIA_BUS_FMT_YUV8_1X24); 308 + imx_drm_set_bus_format(encoder, MEDIA_BUS_FMT_YUV8_1X24); 309 309 break; 310 310 } 311 311 }
+5 -8
drivers/gpu/drm/imx/ipuv3-crtc.c
··· 45 45 struct drm_pending_vblank_event *page_flip_event; 46 46 struct drm_framebuffer *newfb; 47 47 int irq; 48 - u32 interface_pix_fmt; 48 + u32 bus_format; 49 49 int di_hsync_pin; 50 50 int di_vsync_pin; 51 51 }; ··· 145 145 struct ipu_crtc *ipu_crtc = to_ipu_crtc(crtc); 146 146 struct ipu_di_signal_cfg sig_cfg = {}; 147 147 unsigned long encoder_types = 0; 148 - u32 out_pixel_fmt; 149 148 int ret; 150 149 151 150 dev_dbg(ipu_crtc->dev, "%s: mode->hdisplay: %d\n", __func__, ··· 172 173 else 173 174 sig_cfg.clkflags = 0; 174 175 175 - out_pixel_fmt = ipu_crtc->interface_pix_fmt; 176 - 177 176 sig_cfg.enable_pol = 1; 178 177 sig_cfg.clk_pol = 0; 179 - sig_cfg.pixel_fmt = out_pixel_fmt; 178 + sig_cfg.bus_format = ipu_crtc->bus_format; 180 179 sig_cfg.v_to_h_sync = 0; 181 180 sig_cfg.hsync_pin = ipu_crtc->di_hsync_pin; 182 181 sig_cfg.vsync_pin = ipu_crtc->di_vsync_pin; ··· 183 186 184 187 ret = ipu_dc_init_sync(ipu_crtc->dc, ipu_crtc->di, 185 188 mode->flags & DRM_MODE_FLAG_INTERLACE, 186 - out_pixel_fmt, mode->hdisplay); 189 + ipu_crtc->bus_format, mode->hdisplay); 187 190 if (ret) { 188 191 dev_err(ipu_crtc->dev, 189 192 "initializing display controller failed with %d\n", ··· 291 294 } 292 295 293 296 static int ipu_set_interface_pix_fmt(struct drm_crtc *crtc, 294 - u32 pixfmt, int hsync_pin, int vsync_pin) 297 + u32 bus_format, int hsync_pin, int vsync_pin) 295 298 { 296 299 struct ipu_crtc *ipu_crtc = to_ipu_crtc(crtc); 297 300 298 - ipu_crtc->interface_pix_fmt = pixfmt; 301 + ipu_crtc->bus_format = bus_format; 299 302 ipu_crtc->di_hsync_pin = hsync_pin; 300 303 ipu_crtc->di_vsync_pin = vsync_pin; 301 304
+6 -7
drivers/gpu/drm/imx/parallel-display.c
··· 33 33 struct device *dev; 34 34 void *edid; 35 35 int edid_len; 36 - u32 interface_pix_fmt; 36 + u32 bus_format; 37 37 int mode_valid; 38 38 struct drm_display_mode mode; 39 39 struct drm_panel *panel; ··· 118 118 { 119 119 struct imx_parallel_display *imxpd = enc_to_imxpd(encoder); 120 120 121 - imx_drm_panel_format(encoder, imxpd->interface_pix_fmt); 121 + imx_drm_set_bus_format(encoder, imxpd->bus_format); 122 122 } 123 123 124 124 static void imx_pd_encoder_commit(struct drm_encoder *encoder) ··· 225 225 ret = of_property_read_string(np, "interface-pix-fmt", &fmt); 226 226 if (!ret) { 227 227 if (!strcmp(fmt, "rgb24")) 228 - imxpd->interface_pix_fmt = MEDIA_BUS_FMT_RGB888_1X24; 228 + imxpd->bus_format = MEDIA_BUS_FMT_RGB888_1X24; 229 229 else if (!strcmp(fmt, "rgb565")) 230 - imxpd->interface_pix_fmt = MEDIA_BUS_FMT_RGB565_1X16; 230 + imxpd->bus_format = MEDIA_BUS_FMT_RGB565_1X16; 231 231 else if (!strcmp(fmt, "bgr666")) 232 - imxpd->interface_pix_fmt = MEDIA_BUS_FMT_RGB666_1X18; 232 + imxpd->bus_format = MEDIA_BUS_FMT_RGB666_1X18; 233 233 else if (!strcmp(fmt, "lvds666")) 234 - imxpd->interface_pix_fmt = 235 - MEDIA_BUS_FMT_RGB666_1X24_CPADHI; 234 + imxpd->bus_format = MEDIA_BUS_FMT_RGB666_1X24_CPADHI; 236 235 } 237 236 238 237 panel_node = of_parse_phandle(np, "fsl,panel", 0);
+2 -2
drivers/gpu/ipu-v3/ipu-dc.c
··· 168 168 } 169 169 170 170 int ipu_dc_init_sync(struct ipu_dc *dc, struct ipu_di *di, bool interlaced, 171 - u32 pixel_fmt, u32 width) 171 + u32 bus_format, u32 width) 172 172 { 173 173 struct ipu_dc_priv *priv = dc->priv; 174 174 u32 reg = 0; ··· 176 176 177 177 dc->di = ipu_di_get_num(di); 178 178 179 - map = ipu_bus_format_to_map(pixel_fmt); 179 + map = ipu_bus_format_to_map(bus_format); 180 180 if (map < 0) { 181 181 dev_dbg(priv->dev, "IPU_DISP: No MAP\n"); 182 182 return map;
+1 -1
include/video/imx-ipu-v3.h
··· 39 39 40 40 struct videomode mode; 41 41 42 - u32 pixel_fmt; 42 + u32 bus_format; 43 43 u32 v_to_h_sync; 44 44 45 45 #define IPU_DI_CLKMODE_SYNC (1 << 0)