Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mmc: remove unnecessary set_drvdata() function

The driver data will be cleared in device_unbind_cleanup() in driver
core code. So the set_drvdata(..., NULL) called in remove and error
path in probe can be removed.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20230808121513.553143-1-yangyingliang@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

authored by

Yang Yingliang and committed by
Ulf Hansson
283cf357 117d73b1

-8
-1
drivers/mmc/core/block.c
··· 3026 3026 pm_runtime_disable(&card->dev); 3027 3027 pm_runtime_put_noidle(&card->dev); 3028 3028 mmc_blk_remove_req(md); 3029 - dev_set_drvdata(&card->dev, NULL); 3030 3029 destroy_workqueue(card->complete_wq); 3031 3030 } 3032 3031
-2
drivers/mmc/host/moxart-mmc.c
··· 692 692 struct mmc_host *mmc = dev_get_drvdata(&pdev->dev); 693 693 struct moxart_host *host = mmc_priv(mmc); 694 694 695 - dev_set_drvdata(&pdev->dev, NULL); 696 - 697 695 if (!IS_ERR_OR_NULL(host->dma_chan_tx)) 698 696 dma_release_channel(host->dma_chan_tx); 699 697 if (!IS_ERR_OR_NULL(host->dma_chan_rx))
-1
drivers/mmc/host/sunplus-mmc.c
··· 948 948 clk_disable_unprepare(host->clk); 949 949 pm_runtime_put_noidle(&dev->dev); 950 950 pm_runtime_disable(&dev->dev); 951 - platform_set_drvdata(dev, NULL); 952 951 953 952 return 0; 954 953 }
-2
drivers/mmc/host/via-sdmmc.c
··· 1160 1160 unmap: 1161 1161 iounmap(sdhost->mmiobase); 1162 1162 free_mmc_host: 1163 - dev_set_drvdata(&pcidev->dev, NULL); 1164 1163 mmc_free_host(mmc); 1165 1164 release: 1166 1165 pci_release_regions(pcidev); ··· 1211 1212 writeb(gatt, sdhost->pcictrl_mmiobase + VIA_CRDR_PCICLKGATT); 1212 1213 1213 1214 iounmap(sdhost->mmiobase); 1214 - dev_set_drvdata(&pcidev->dev, NULL); 1215 1215 mmc_free_host(sdhost->mmc); 1216 1216 pci_release_regions(pcidev); 1217 1217 pci_disable_device(pcidev);
-2
drivers/mmc/host/wbsd.c
··· 1264 1264 del_timer_sync(&host->ignore_timer); 1265 1265 1266 1266 mmc_free_host(mmc); 1267 - 1268 - dev_set_drvdata(dev, NULL); 1269 1267 } 1270 1268 1271 1269 /*