Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

uacce: vma_close clears q->qfrs when freeing qfrs

vma_close frees qfrs but not clears q->qfrs, which still points
to the freed object, leading to subsequent mmap fail.
So vma_close clears q->qfrs as well.

Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Link: https://lore.kernel.org/r/20230511095921.9331-3-zhangfei.gao@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Zhangfei Gao and committed by
Greg Kroah-Hartman
282c22a8 df1b056d

+7 -4
+7 -4
drivers/misc/uacce/uacce.c
··· 200 200 static void uacce_vma_close(struct vm_area_struct *vma) 201 201 { 202 202 struct uacce_queue *q = vma->vm_private_data; 203 - struct uacce_qfile_region *qfr = NULL; 204 203 205 - if (vma->vm_pgoff < UACCE_MAX_REGION) 206 - qfr = q->qfrs[vma->vm_pgoff]; 204 + if (vma->vm_pgoff < UACCE_MAX_REGION) { 205 + struct uacce_qfile_region *qfr = q->qfrs[vma->vm_pgoff]; 207 206 208 - kfree(qfr); 207 + mutex_lock(&q->mutex); 208 + q->qfrs[vma->vm_pgoff] = NULL; 209 + mutex_unlock(&q->mutex); 210 + kfree(qfr); 211 + } 209 212 } 210 213 211 214 static const struct vm_operations_struct uacce_vm_ops = {