sched/fair: Avoid newidle balance for !active CPUs

On CPU hot unplug, when parking the last kthread we'll try and
schedule into idle to kill the CPU. This last schedule can (and does)
trigger newidle balance because at this point the sched domains are
still up because of commit:

77d1dfda0e79 ("sched/topology, cpuset: Avoid spurious/wrong domain rebuilds")

Obviously pulling tasks to an already offline CPU is a bad idea, and
all balancing operations _should_ be subject to cpu_active_mask, make
it so.

Reported-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: 77d1dfda0e79 ("sched/topology, cpuset: Avoid spurious/wrong domain rebuilds")
Link: http://lkml.kernel.org/r/20170907150613.994135806@infradead.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>

authored by

Peter Zijlstra and committed by
Ingo Molnar
2800486e 46123355

+6
+6
kernel/sched/fair.c
··· 8448 8448 this_rq->idle_stamp = rq_clock(this_rq); 8449 8449 8450 8450 /* 8451 + * Do not pull tasks towards !active CPUs... 8452 + */ 8453 + if (!cpu_active(this_cpu)) 8454 + return 0; 8455 + 8456 + /* 8451 8457 * This is OK, because current is on_cpu, which avoids it being picked 8452 8458 * for load-balance and preemption/IRQs are still disabled avoiding 8453 8459 * further scheduler activity on it and we're being very careful to