Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

lp8727_charger: Change i2c functions

On writing single byte via i2c, use i2c_smbus_write_byte_data()
rather than i2c_smbus_write_i2c_block_data().

Name changes :
lp8727_i2c_read() -> lp8727_read_bytes()
lp8727_i2c_write() -> removed
lp8727_i2c_read_byte() -> lp8727_read_byte()
lp8727_i2c_write_byte() -> lp8727_write_byte()

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>

authored by

Kim, Milo and committed by
Anton Vorontsov
27aefa3b 7da6334e

+20 -28
+20 -28
drivers/power/lp8727_charger.c
··· 92 92 enum lp8727_dev_id devid; 93 93 }; 94 94 95 - static int lp8727_i2c_read(struct lp8727_chg *pchg, u8 reg, u8 *data, u8 len) 95 + static int lp8727_read_bytes(struct lp8727_chg *pchg, u8 reg, u8 *data, u8 len) 96 96 { 97 97 s32 ret; 98 98 ··· 103 103 return (ret != len) ? -EIO : 0; 104 104 } 105 105 106 - static int lp8727_i2c_write(struct lp8727_chg *pchg, u8 reg, u8 *data, u8 len) 106 + static inline int lp8727_read_byte(struct lp8727_chg *pchg, u8 reg, u8 *data) 107 107 { 108 - s32 ret; 108 + return lp8727_read_bytes(pchg, reg, data, 1); 109 + } 110 + 111 + static int lp8727_write_byte(struct lp8727_chg *pchg, u8 reg, u8 data) 112 + { 113 + int ret; 109 114 110 115 mutex_lock(&pchg->xfer_lock); 111 - ret = i2c_smbus_write_i2c_block_data(pchg->client, reg, len, data); 116 + ret = i2c_smbus_write_byte_data(pchg->client, reg, data); 112 117 mutex_unlock(&pchg->xfer_lock); 113 118 114 119 return ret; 115 - } 116 - 117 - static inline int lp8727_i2c_read_byte(struct lp8727_chg *pchg, u8 reg, 118 - u8 *data) 119 - { 120 - return lp8727_i2c_read(pchg, reg, data, 1); 121 - } 122 - 123 - static inline int lp8727_i2c_write_byte(struct lp8727_chg *pchg, u8 reg, 124 - u8 *data) 125 - { 126 - return lp8727_i2c_write(pchg, reg, data, 1); 127 120 } 128 121 129 122 static int lp8727_is_charger_attached(const char *name, int id) ··· 137 144 int ret; 138 145 139 146 val = ID200_EN | ADC_EN | CP_EN; 140 - ret = lp8727_i2c_write_byte(pchg, CTRL1, &val); 147 + ret = lp8727_write_byte(pchg, CTRL1, val); 141 148 if (ret) 142 149 return ret; 143 150 144 151 val = INT_EN | CHGDET_EN; 145 - ret = lp8727_i2c_write_byte(pchg, CTRL2, &val); 152 + ret = lp8727_write_byte(pchg, CTRL2, val); 146 153 if (ret) 147 154 return ret; 148 155 ··· 152 159 static int lp8727_is_dedicated_charger(struct lp8727_chg *pchg) 153 160 { 154 161 u8 val; 155 - lp8727_i2c_read_byte(pchg, STATUS1, &val); 162 + lp8727_read_byte(pchg, STATUS1, &val); 156 163 return (val & DCPORT); 157 164 } 158 165 159 166 static int lp8727_is_usb_charger(struct lp8727_chg *pchg) 160 167 { 161 168 u8 val; 162 - lp8727_i2c_read_byte(pchg, STATUS1, &val); 169 + lp8727_read_byte(pchg, STATUS1, &val); 163 170 return (val & CHPORT); 164 171 } 165 172 166 173 static void lp8727_ctrl_switch(struct lp8727_chg *pchg, u8 sw) 167 174 { 168 - u8 val = sw; 169 - lp8727_i2c_write_byte(pchg, SWCTRL, &val); 175 + lp8727_write_byte(pchg, SWCTRL, sw); 170 176 } 171 177 172 178 static void lp8727_id_detection(struct lp8727_chg *pchg, u8 id, int vbusin) ··· 205 213 { 206 214 u8 val; 207 215 208 - lp8727_i2c_read_byte(pchg, CTRL2, &val); 216 + lp8727_read_byte(pchg, CTRL2, &val); 209 217 val |= CHGDET_EN; 210 - lp8727_i2c_write_byte(pchg, CTRL2, &val); 218 + lp8727_write_byte(pchg, CTRL2, val); 211 219 } 212 220 213 221 static void lp8727_delayed_func(struct work_struct *_work) ··· 216 224 struct lp8727_chg *pchg = 217 225 container_of(_work, struct lp8727_chg, work.work); 218 226 219 - if (lp8727_i2c_read(pchg, INT1, intstat, 2)) { 227 + if (lp8727_read_bytes(pchg, INT1, intstat, 2)) { 220 228 dev_err(pchg->dev, "can not read INT registers\n"); 221 229 return; 222 230 } ··· 300 308 switch (psp) { 301 309 case POWER_SUPPLY_PROP_STATUS: 302 310 if (lp8727_is_charger_attached(psy->name, pchg->devid)) { 303 - lp8727_i2c_read_byte(pchg, STATUS1, &read); 311 + lp8727_read_byte(pchg, STATUS1, &read); 304 312 if (((read & CHGSTAT) >> 4) == EOC) 305 313 val->intval = POWER_SUPPLY_STATUS_FULL; 306 314 else ··· 310 318 } 311 319 break; 312 320 case POWER_SUPPLY_PROP_HEALTH: 313 - lp8727_i2c_read_byte(pchg, STATUS2, &read); 321 + lp8727_read_byte(pchg, STATUS2, &read); 314 322 read = (read & TEMP_STAT) >> 5; 315 323 if (read >= 0x1 && read <= 0x3) 316 324 val->intval = POWER_SUPPLY_HEALTH_OVERHEAT; ··· 351 359 eoc_level = pchg->chg_parm->eoc_level; 352 360 ichg = pchg->chg_parm->ichg; 353 361 val = (ichg << 4) | eoc_level; 354 - lp8727_i2c_write_byte(pchg, CHGCTRL2, &val); 362 + lp8727_write_byte(pchg, CHGCTRL2, val); 355 363 } 356 364 } 357 365 }