Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

samples/seccomp: be less stupid about cross compiling

The seccomp filters are currently built for the build host, not for the
machine that they are going to run on, but they are also built for with
the -m32 flag if the kernel is built for a 32 bit machine, both of which
seems rather odd.

It broke allyesconfig on my machine, which is x86-64, but building for
32 bit ARM, with this error message:

In file included from /usr/include/stdio.h:28:0,
from samples/seccomp/bpf-fancy.c:15:
/usr/include/features.h:324:26: fatal error: bits/predefs.h: No such file or directory

because there are no 32 bit libc headers installed on this machine. We
should really be building all the samples for the target machine rather
than the build host, but since the infrastructure for that appears to be
missing right now, let's be a little bit smarter and not pass the '-m32'
flag to the HOSTCC when cross- compiling.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Kees Cook <keescook@chromium.org>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: James Morris <james.l.morris@oracle.com>
Acked-by: Will Drewry <wad@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Arnd Bergmann and committed by
Linus Torvalds
275aaa68 326b1ffc

+2
+2
samples/seccomp/Makefile
··· 19 19 20 20 # Try to match the kernel target. 21 21 ifndef CONFIG_64BIT 22 + ifndef CROSS_COMPILE 22 23 23 24 # s390 has -m31 flag to build 31 bit binaries 24 25 ifndef CONFIG_S390 ··· 35 34 HOSTLOADLIBES_bpf-direct += $(MFLAG) 36 35 HOSTLOADLIBES_bpf-fancy += $(MFLAG) 37 36 HOSTLOADLIBES_dropper += $(MFLAG) 37 + endif 38 38 endif 39 39 40 40 # Tell kbuild to always build the programs