Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

powerpc, ocxl: Fix extraction of struct xive_irq_data

Commit cc0cc23babc9 ("powerpc/xive: Untangle xive from child interrupt
controller drivers") changed xive_irq_data to be stashed to chip_data
instead of handler_data. However, multiple places are still attempting to
read xive_irq_data from handler_data and get a NULL pointer deference bug.

Update them to read xive_irq_data from chip_data.

Non-XIVE files which touch xive_irq_data seem quite strange to me,
especially the ocxl driver. I think there ought to be an alternative
platform-independent solution, instead of touching XIVE's data directly.
Therefore, I think this whole thing should be cleaned up. But perhaps I
just misunderstand something. In any case, this cleanup would not be
trivial; for now, just get things working again.

Fixes: cc0cc23babc9 ("powerpc/xive: Untangle xive from child interrupt controller drivers")
Reported-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Closes: https://lore.kernel.org/linuxppc-dev/68e48df8.170a0220.4b4b0.217d@mx.google.com/
Signed-off-by: Nam Cao <namcao@linutronix.de>
Reviewed-by: Ganesh Goudar <ganeshgr@linux.ibm.com>
Acked-by: Andrew Donnellan <ajd@linux.ibm.com> # ocxl
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20251008081359.1382699-1-namcao@linutronix.de

authored by

Nam Cao and committed by
Madhavan Srinivasan
2743cf75 ef3e73a9

+7 -11
+4 -8
arch/powerpc/kvm/book3s_xive.c
··· 916 916 * it fires once. 917 917 */ 918 918 if (single_escalation) { 919 - struct irq_data *d = irq_get_irq_data(xc->esc_virq[prio]); 920 - struct xive_irq_data *xd = irq_data_get_irq_handler_data(d); 919 + struct xive_irq_data *xd = irq_get_chip_data(xc->esc_virq[prio]); 921 920 922 921 xive_vm_esb_load(xd, XIVE_ESB_SET_PQ_01); 923 922 vcpu->arch.xive_esc_raddr = xd->eoi_page; ··· 1611 1612 1612 1613 /* Grab info about irq */ 1613 1614 state->pt_number = hw_irq; 1614 - state->pt_data = irq_data_get_irq_handler_data(host_data); 1615 + state->pt_data = irq_data_get_irq_chip_data(host_data); 1615 1616 1616 1617 /* 1617 1618 * Configure the IRQ to match the existing configuration of ··· 1786 1787 */ 1787 1788 void xive_cleanup_single_escalation(struct kvm_vcpu *vcpu, int irq) 1788 1789 { 1789 - struct irq_data *d = irq_get_irq_data(irq); 1790 - struct xive_irq_data *xd = irq_data_get_irq_handler_data(d); 1790 + struct xive_irq_data *xd = irq_get_chip_data(irq); 1791 1791 1792 1792 /* 1793 1793 * This slightly odd sequence gives the right result ··· 2825 2827 i0, i1); 2826 2828 } 2827 2829 if (xc->esc_virq[i]) { 2828 - struct irq_data *d = irq_get_irq_data(xc->esc_virq[i]); 2829 - struct xive_irq_data *xd = 2830 - irq_data_get_irq_handler_data(d); 2830 + struct xive_irq_data *xd = irq_get_chip_data(xc->esc_virq[i]); 2831 2831 u64 pq = xive_vm_esb_load(xd, XIVE_ESB_GET); 2832 2832 2833 2833 seq_printf(m, " ESC %d %c%c EOI @%llx",
+1 -1
arch/powerpc/platforms/powernv/vas.c
··· 121 121 return -EINVAL; 122 122 } 123 123 124 - xd = irq_get_handler_data(vinst->virq); 124 + xd = irq_get_chip_data(vinst->virq); 125 125 if (!xd) { 126 126 pr_err("Inst%d: Invalid virq %d\n", 127 127 vinst->vas_id, vinst->virq);
+1 -1
arch/powerpc/sysdev/xive/common.c
··· 1580 1580 cpu, irq); 1581 1581 #endif 1582 1582 raw_spin_lock(&desc->lock); 1583 - xd = irq_desc_get_handler_data(desc); 1583 + xd = irq_desc_get_chip_data(desc); 1584 1584 1585 1585 /* 1586 1586 * Clear saved_p to indicate that it's no longer pending
+1 -1
drivers/misc/ocxl/afu_irq.c
··· 203 203 mutex_lock(&ctx->irq_lock); 204 204 irq = idr_find(&ctx->irq_idr, irq_id); 205 205 if (irq) { 206 - xd = irq_get_handler_data(irq->virq); 206 + xd = irq_get_chip_data(irq->virq); 207 207 addr = xd ? xd->trig_page : 0; 208 208 } 209 209 mutex_unlock(&ctx->irq_lock);