Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: phy: phy_led_triggers: Fix a possible null-pointer dereference in phy_led_trigger_change_speed()

In phy_led_trigger_change_speed(), there is an if statement on line 48
to check whether phy->last_triggered is NULL:
if (!phy->last_triggered)

When phy->last_triggered is NULL, it is used on line 52:
led_trigger_event(&phy->last_triggered->trigger, LED_OFF);

Thus, a possible null-pointer dereference may occur.

To fix this bug, led_trigger_event(&phy->last_triggered->trigger,
LED_OFF) is called when phy->last_triggered is not NULL.

This bug is found by a static analysis tool STCheck written by
the OSLAB group in Tsinghua University.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Jia-Ju Bai and committed by
David S. Miller
271da132 e29903c4

+2 -1
+2 -1
drivers/net/phy/phy_led_triggers.c
··· 48 48 if (!phy->last_triggered) 49 49 led_trigger_event(&phy->led_link_trigger->trigger, 50 50 LED_FULL); 51 + else 52 + led_trigger_event(&phy->last_triggered->trigger, LED_OFF); 51 53 52 - led_trigger_event(&phy->last_triggered->trigger, LED_OFF); 53 54 led_trigger_event(&plt->trigger, LED_FULL); 54 55 phy->last_triggered = plt; 55 56 }