Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/i915/icl: Fix CRC mismatch error for DP link layer compliance

Setting the pixel rounding bit to 1 in PIPE_CHICKEN register allows
to passthrough FB pixels unmodified across pipe. This fixes the failures
for DP link layer compliance tests 4.4.1.1, 4.4.1.2 & 4.4.1.3.
(Lineage #1605353570)

v2: This is also needed to fix failing IGT test case kms_cursor_crc on
ICL.(Mika Kahola)
Make macros consistent with i915_reg.h comments.(Jani Nikula)

Cc: Clint Taylor <clinton.a.taylor@intel.com>
Cc: Mika Kahola <mika.kahola@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190307021412.18626-1-aditya.swarup@intel.com
References: https://bugs.freedesktop.org/show_bug.cgi?id=103232

authored by

Aditya Swarup and committed by
Maarten Lankhorst
26eeea15 f4ecb8ae

+14 -7
+7 -6
drivers/gpu/drm/i915/i915_reg.h
··· 7659 7659 #define GEN9_LBS_SLA_RETRY_TIMER_DECREMENT_ENABLE (1 << 2) 7660 7660 7661 7661 /*GEN11 chicken */ 7662 - #define _PIPEA_CHICKEN 0x70038 7663 - #define _PIPEB_CHICKEN 0x71038 7664 - #define _PIPEC_CHICKEN 0x72038 7665 - #define PER_PIXEL_ALPHA_BYPASS_EN (1 << 7) 7666 - #define PIPE_CHICKEN(pipe) _MMIO_PIPE(pipe, _PIPEA_CHICKEN,\ 7667 - _PIPEB_CHICKEN) 7662 + #define _PIPEA_CHICKEN 0x70038 7663 + #define _PIPEB_CHICKEN 0x71038 7664 + #define _PIPEC_CHICKEN 0x72038 7665 + #define PIPE_CHICKEN(pipe) _MMIO_PIPE(pipe, _PIPEA_CHICKEN,\ 7666 + _PIPEB_CHICKEN) 7667 + #define PIXEL_ROUNDING_TRUNC_FB_PASSTHRU (1 << 15) 7668 + #define PER_PIXEL_ALPHA_BYPASS_EN (1 << 7) 7668 7669 7669 7670 /* PCH */ 7670 7671
+7 -1
drivers/gpu/drm/i915/intel_display.c
··· 3933 3933 * and rounding for per-pixel values 00 and 0xff 3934 3934 */ 3935 3935 tmp |= PER_PIXEL_ALPHA_BYPASS_EN; 3936 - 3936 + /* 3937 + * Display WA # 1605353570: icl 3938 + * Set the pixel rounding bit to 1 for allowing 3939 + * passthrough of Frame buffer pixels unmodified 3940 + * across pipe 3941 + */ 3942 + tmp |= PIXEL_ROUNDING_TRUNC_FB_PASSTHRU; 3937 3943 I915_WRITE(PIPE_CHICKEN(pipe), tmp); 3938 3944 } 3939 3945