Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbcon: uninline four foo_update_attr() functions

This patch uninlines four similar functions, foo_update_attr(), in four
fbcon-related files.

These functions contain loops, two of theam have _nested_ loops, and they
have more than one callsite each. I think they should not be inlined.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Denys Vlasenko and committed by
Linus Torvalds
26c5be3c da909ce4

+4 -4
+1 -1
drivers/video/console/bitblit.c
··· 22 22 /* 23 23 * Accelerated handlers. 24 24 */ 25 - static inline void update_attr(u8 *dst, u8 *src, int attribute, 25 + static void update_attr(u8 *dst, u8 *src, int attribute, 26 26 struct vc_data *vc) 27 27 { 28 28 int i, offset = (vc->vc_font.height < 10) ? 1 : 2;
+1 -1
drivers/video/console/fbcon_ccw.c
··· 22 22 * Rotation 270 degrees 23 23 */ 24 24 25 - static inline void ccw_update_attr(u8 *dst, u8 *src, int attribute, 25 + static void ccw_update_attr(u8 *dst, u8 *src, int attribute, 26 26 struct vc_data *vc) 27 27 { 28 28 int i, j, offset = (vc->vc_font.height < 10) ? 1 : 2;
+1 -1
drivers/video/console/fbcon_cw.c
··· 22 22 * Rotation 90 degrees 23 23 */ 24 24 25 - static inline void cw_update_attr(u8 *dst, u8 *src, int attribute, 25 + static void cw_update_attr(u8 *dst, u8 *src, int attribute, 26 26 struct vc_data *vc) 27 27 { 28 28 int i, j, offset = (vc->vc_font.height < 10) ? 1 : 2;
+1 -1
drivers/video/console/fbcon_ud.c
··· 22 22 * Rotation 180 degrees 23 23 */ 24 24 25 - static inline void ud_update_attr(u8 *dst, u8 *src, int attribute, 25 + static void ud_update_attr(u8 *dst, u8 *src, int attribute, 26 26 struct vc_data *vc) 27 27 { 28 28 int i, offset = (vc->vc_font.height < 10) ? 1 : 2;