tjh.dev
Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
staging: usbip: reformat function pickup_urb_and_free_priv
re-indent funtion "pickup_urb_and_free_priv" to improve readability.
Signed-off-by: Stefan Reif <ke42caxa@cip.cs.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
authored by
Stefan Reif
and committed by
Greg Kroah-Hartman
2663d79b
c5a73ee2
+26
-22
+26
-22
drivers/staging/usbip/vhci_rx.c
+26
-22
drivers/staging/usbip/vhci_rx.c
···
31
31
int status;
32
32
33
33
list_for_each_entry_safe(priv, tmp, &vdev->priv_rx, list) {
34
-
if (priv->seqnum == seqnum) {
35
-
urb = priv->urb;
36
-
status = urb->status;
34
+
if (priv->seqnum != seqnum)
35
+
continue;
37
36
38
-
usbip_dbg_vhci_rx("find urb %p vurb %p seqnum %u\n",
39
-
urb, priv, seqnum);
37
+
urb = priv->urb;
38
+
status = urb->status;
40
39
41
-
/* TODO: fix logic here to improve indent situtation */
42
-
if (status != -EINPROGRESS) {
43
-
if (status == -ENOENT ||
44
-
status == -ECONNRESET)
45
-
dev_info(&urb->dev->dev,
46
-
"urb %p was unlinked "
47
-
"%ssynchronuously.\n", urb,
48
-
status == -ENOENT ? "" : "a");
49
-
else
50
-
dev_info(&urb->dev->dev,
51
-
"urb %p may be in a error, "
52
-
"status %d\n", urb, status);
53
-
}
40
+
usbip_dbg_vhci_rx("find urb %p vurb %p seqnum %u\n",
41
+
urb, priv, seqnum);
54
42
55
-
list_del(&priv->list);
56
-
kfree(priv);
57
-
urb->hcpriv = NULL;
58
-
43
+
switch (status) {
44
+
case -ENOENT:
45
+
/* fall through */
46
+
case -ECONNRESET:
47
+
dev_info(&urb->dev->dev,
48
+
"urb %p was unlinked %ssynchronuously.\n", urb,
49
+
status == -ENOENT ? "" : "a");
59
50
break;
51
+
case -EINPROGRESS:
52
+
/* no info output */
53
+
break;
54
+
default:
55
+
dev_info(&urb->dev->dev,
56
+
"urb %p may be in a error, status %d\n", urb,
57
+
status);
60
58
}
59
+
60
+
list_del(&priv->list);
61
+
kfree(priv);
62
+
urb->hcpriv = NULL;
63
+
64
+
break;
61
65
}
62
66
63
67
return urb;