Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

netns: remove BUG_ONs from net_generic()

This inline has ~500 callsites.

On 04/14/2015 08:37 PM, David Miller wrote:
> That BUG_ON() was added 7 years ago, and I don't remember it ever
> triggering or helping us diagnose something, so just remove it and
> keep the function inlined.

On x86 allyesconfig build:

text data bss dec hex filename
82447071 22255384 20627456 125329911 77861f7 vmlinux4
82441375 22255384 20627456 125324215 7784bb7 vmlinux5prime

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Eric W. Biederman <ebiederm@xmission.com>
CC: David S. Miller <davem@davemloft.net>
CC: Jan Engelhardt <jengelh@medozas.de>
CC: Jiri Pirko <jpirko@redhat.com>
CC: linux-kernel@vger.kernel.org
CC: netdev@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Denys Vlasenko and committed by
David S. Miller
2591ffd3 2c153959

-2
-2
include/net/netns/generic.h
··· 38 38 39 39 rcu_read_lock(); 40 40 ng = rcu_dereference(net->gen); 41 - BUG_ON(id == 0 || id > ng->len); 42 41 ptr = ng->ptr[id - 1]; 43 42 rcu_read_unlock(); 44 43 45 - BUG_ON(!ptr); 46 44 return ptr; 47 45 } 48 46 #endif