Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm: komeda: Fix an issue related to normalized zpos

We use komeda_crtc_normalize_zpos to normalize zpos of affected planes
to their blending zorder in CU. If there's only one slave plane in
affected planes and its layer_split property is enabled, order++ for
its split layer, so that when calculating the normalized_zpos
of master planes, the split layer of the slave plane is included, but
the max_slave_zorder does not include the split layer and keep zero
because there's only one slave plane in affacted planes, although we
actually use two slave layers in this commit.

In most cases, this bug does not result in a commit failure, but assume
the following situation:
slave_layer 0: zpos = 0, layer split enabled, normalized_zpos =
0;(use slave_layer 2 as its split layer)
master_layer 0: zpos = 2, layer_split enabled, normalized_zpos =
2;(use master_layer 2 as its split layer)
master_layer 1: zpos = 4, normalized_zpos = 4;
master_layer 3: zpos = 5, normalized_zpos = 5;
kcrtc_st->max_slave_zorder = 0;
When we use master_layer 3 as a input of CU in function
komeda_compiz_set_input and check it with function
komeda_component_check_input, the parameter idx is equal to
normailzed_zpos minus max_slave_zorder, the value of idx is 5
and is euqal to CU's max_active_inputs, so that
komeda_component_check_input returns a -EINVAL value.

To fix the bug described above, when calculating the max_slave_zorder
with the layer_split enabled, count the split layer in this calculation
directly.

Signed-off-by: hongchi.peng <hongchi.peng@siengine.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240826024517.3739-1-hongchi.peng@siengine.com

authored by

hongchi.peng and committed by
Liviu Dudau
258905cb 9d824c7f

+7 -3
+7 -3
drivers/gpu/drm/arm/display/komeda/komeda_kms.c
··· 160 160 struct drm_plane *plane; 161 161 struct list_head zorder_list; 162 162 int order = 0, err; 163 + u32 slave_zpos = 0; 163 164 164 165 DRM_DEBUG_ATOMIC("[CRTC:%d:%s] calculating normalized zpos values\n", 165 166 crtc->base.id, crtc->name); ··· 200 199 plane_st->zpos, plane_st->normalized_zpos); 201 200 202 201 /* calculate max slave zorder */ 203 - if (has_bit(drm_plane_index(plane), kcrtc->slave_planes)) 202 + if (has_bit(drm_plane_index(plane), kcrtc->slave_planes)) { 203 + slave_zpos = plane_st->normalized_zpos; 204 + if (to_kplane_st(plane_st)->layer_split) 205 + slave_zpos++; 204 206 kcrtc_st->max_slave_zorder = 205 - max(plane_st->normalized_zpos, 206 - kcrtc_st->max_slave_zorder); 207 + max(slave_zpos, kcrtc_st->max_slave_zorder); 208 + } 207 209 } 208 210 209 211 crtc_st->zpos_changed = true;