tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

scsi: libsas: Delete lldd_clear_aca callback

This callback is never called, so remove support.

Link: https://lore.kernel.org/r/1645112566-115804-4-git-send-email-john.garry@huawei.com
Tested-by: Yihang Li <liyihang6@hisilicon.com>
Tested-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Jack Wang <jinpu.wang@ionos.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

John Garry and committed by
Martin K. Petersen 25882c82 1d6049a3

-72
-2
Documentation/scsi/libsas.rst
··· 207 207 /* Task Management Functions. Must be called from process context. */ 208 208 int (*lldd_abort_task)(struct sas_task *); 209 209 int (*lldd_abort_task_set)(struct domain_device *, u8 *lun); 210 - int (*lldd_clear_aca)(struct domain_device *, u8 *lun); 211 210 int (*lldd_clear_task_set)(struct domain_device *, u8 *lun); 212 211 int (*lldd_I_T_nexus_reset)(struct domain_device *); 213 212 int (*lldd_lu_reset)(struct domain_device *, u8 *lun); ··· 261 262 262 263 my_ha->sas_ha.lldd_abort_task = my_abort_task; 263 264 my_ha->sas_ha.lldd_abort_task_set = my_abort_task_set; 264 - my_ha->sas_ha.lldd_clear_aca = my_clear_aca; 265 265 my_ha->sas_ha.lldd_clear_task_set = my_clear_task_set; 266 266 my_ha->sas_ha.lldd_I_T_nexus_reset= NULL; (2) 267 267 my_ha->sas_ha.lldd_lu_reset = my_lu_reset;
-1
drivers/scsi/aic94xx/aic94xx.h
··· 60 60 /* ---------- TMFs ---------- */ 61 61 int asd_abort_task(struct sas_task *); 62 62 int asd_abort_task_set(struct domain_device *, u8 *lun); 63 - int asd_clear_aca(struct domain_device *, u8 *lun); 64 63 int asd_clear_task_set(struct domain_device *, u8 *lun); 65 64 int asd_lu_reset(struct domain_device *, u8 *lun); 66 65 int asd_I_T_nexus_reset(struct domain_device *dev);
-1
drivers/scsi/aic94xx/aic94xx_init.c
··· 960 960 961 961 .lldd_abort_task = asd_abort_task, 962 962 .lldd_abort_task_set = asd_abort_task_set, 963 - .lldd_clear_aca = asd_clear_aca, 964 963 .lldd_clear_task_set = asd_clear_task_set, 965 964 .lldd_I_T_nexus_reset = asd_I_T_nexus_reset, 966 965 .lldd_lu_reset = asd_lu_reset,
-9
drivers/scsi/aic94xx/aic94xx_tmf.c
··· 644 644 return res; 645 645 } 646 646 647 - int asd_clear_aca(struct domain_device *dev, u8 *lun) 648 - { 649 - int res = asd_initiate_ssp_tmf(dev, lun, TMF_CLEAR_ACA, 0); 650 - 651 - if (res == TMF_RESP_FUNC_COMPLETE) 652 - asd_clear_nexus_I_T_L(dev, lun); 653 - return res; 654 - } 655 - 656 647 int asd_clear_task_set(struct domain_device *dev, u8 *lun) 657 648 { 658 649 int res = asd_initiate_ssp_tmf(dev, lun, TMF_CLEAR_TASK_SET, 0);
-12
drivers/scsi/hisi_sas/hisi_sas_main.c
··· 1793 1793 return rc; 1794 1794 } 1795 1795 1796 - static int hisi_sas_clear_aca(struct domain_device *device, u8 *lun) 1797 - { 1798 - struct hisi_sas_tmf_task tmf_task; 1799 - int rc; 1800 - 1801 - tmf_task.tmf = TMF_CLEAR_ACA; 1802 - rc = hisi_sas_debug_issue_ssp_tmf(device, lun, &tmf_task); 1803 - 1804 - return rc; 1805 - } 1806 - 1807 1796 #define I_T_NEXUS_RESET_PHYUP_TIMEOUT (2 * HZ) 1808 1797 1809 1798 static int hisi_sas_debug_I_T_nexus_reset(struct domain_device *device) ··· 2322 2333 .lldd_control_phy = hisi_sas_control_phy, 2323 2334 .lldd_abort_task = hisi_sas_abort_task, 2324 2335 .lldd_abort_task_set = hisi_sas_abort_task_set, 2325 - .lldd_clear_aca = hisi_sas_clear_aca, 2326 2336 .lldd_I_T_nexus_reset = hisi_sas_I_T_nexus_reset, 2327 2337 .lldd_lu_reset = hisi_sas_lu_reset, 2328 2338 .lldd_query_task = hisi_sas_query_task,
-1
drivers/scsi/isci/init.c
··· 193 193 /* Task Management Functions. Must be called from process context. */ 194 194 .lldd_abort_task = isci_task_abort_task, 195 195 .lldd_abort_task_set = isci_task_abort_task_set, 196 - .lldd_clear_aca = isci_task_clear_aca, 197 196 .lldd_clear_task_set = isci_task_clear_task_set, 198 197 .lldd_I_T_nexus_reset = isci_task_I_T_nexus_reset, 199 198 .lldd_lu_reset = isci_task_lu_reset,
-18
drivers/scsi/isci/task.c
··· 621 621 622 622 623 623 /** 624 - * isci_task_clear_aca() - This function is one of the SAS Domain Template 625 - * functions. This is one of the Task Management functoins called by libsas. 626 - * @d_device: This parameter specifies the domain device associated with this 627 - * request. 628 - * @lun: This parameter specifies the lun associated with this request. 629 - * 630 - * status, zero indicates success. 631 - */ 632 - int isci_task_clear_aca( 633 - struct domain_device *d_device, 634 - u8 *lun) 635 - { 636 - return TMF_RESP_FUNC_FAILED; 637 - } 638 - 639 - 640 - 641 - /** 642 624 * isci_task_clear_task_set() - This function is one of the SAS Domain Template 643 625 * functions. This is one of the Task Management functoins called by libsas. 644 626 * @d_device: This parameter specifies the domain device associated with this
-4
drivers/scsi/isci/task.h
··· 140 140 struct domain_device *d_device, 141 141 u8 *lun); 142 142 143 - int isci_task_clear_aca( 144 - struct domain_device *d_device, 145 - u8 *lun); 146 - 147 143 int isci_task_clear_task_set( 148 144 struct domain_device *d_device, 149 145 u8 *lun);
-1
drivers/scsi/mvsas/mv_init.c
··· 64 64 65 65 .lldd_abort_task = mvs_abort_task, 66 66 .lldd_abort_task_set = mvs_abort_task_set, 67 - .lldd_clear_aca = mvs_clear_aca, 68 67 .lldd_clear_task_set = mvs_clear_task_set, 69 68 .lldd_I_T_nexus_reset = mvs_I_T_nexus_reset, 70 69 .lldd_lu_reset = mvs_lu_reset,
-11
drivers/scsi/mvsas/mv_sas.c
··· 1550 1550 return rc; 1551 1551 } 1552 1552 1553 - int mvs_clear_aca(struct domain_device *dev, u8 *lun) 1554 - { 1555 - int rc = TMF_RESP_FUNC_FAILED; 1556 - struct mvs_tmf_task tmf_task; 1557 - 1558 - tmf_task.tmf = TMF_CLEAR_ACA; 1559 - rc = mvs_debug_issue_ssp_tmf(dev, lun, &tmf_task); 1560 - 1561 - return rc; 1562 - } 1563 - 1564 1553 int mvs_clear_task_set(struct domain_device *dev, u8 *lun) 1565 1554 { 1566 1555 int rc = TMF_RESP_FUNC_FAILED;
-1
drivers/scsi/mvsas/mv_sas.h
··· 441 441 int mvs_queue_command(struct sas_task *task, gfp_t gfp_flags); 442 442 int mvs_abort_task(struct sas_task *task); 443 443 int mvs_abort_task_set(struct domain_device *dev, u8 *lun); 444 - int mvs_clear_aca(struct domain_device *dev, u8 *lun); 445 444 int mvs_clear_task_set(struct domain_device *dev, u8 * lun); 446 445 void mvs_port_formed(struct asd_sas_phy *sas_phy); 447 446 void mvs_port_deformed(struct asd_sas_phy *sas_phy);
-1
drivers/scsi/pm8001/pm8001_init.c
··· 123 123 124 124 .lldd_abort_task = pm8001_abort_task, 125 125 .lldd_abort_task_set = pm8001_abort_task_set, 126 - .lldd_clear_aca = pm8001_clear_aca, 127 126 .lldd_clear_task_set = pm8001_clear_task_set, 128 127 .lldd_I_T_nexus_reset = pm8001_I_T_nexus_reset, 129 128 .lldd_lu_reset = pm8001_lu_reset,
-8
drivers/scsi/pm8001/pm8001_sas.c
··· 1358 1358 return pm8001_issue_ssp_tmf(dev, lun, &tmf_task); 1359 1359 } 1360 1360 1361 - int pm8001_clear_aca(struct domain_device *dev, u8 *lun) 1362 - { 1363 - struct pm8001_tmf_task tmf_task; 1364 - 1365 - tmf_task.tmf = TMF_CLEAR_ACA; 1366 - return pm8001_issue_ssp_tmf(dev, lun, &tmf_task); 1367 - } 1368 - 1369 1361 int pm8001_clear_task_set(struct domain_device *dev, u8 *lun) 1370 1362 { 1371 1363 struct pm8001_tmf_task tmf_task;
-1
drivers/scsi/pm8001/pm8001_sas.h
··· 649 649 int pm8001_queue_command(struct sas_task *task, gfp_t gfp_flags); 650 650 int pm8001_abort_task(struct sas_task *task); 651 651 int pm8001_abort_task_set(struct domain_device *dev, u8 *lun); 652 - int pm8001_clear_aca(struct domain_device *dev, u8 *lun); 653 652 int pm8001_clear_task_set(struct domain_device *dev, u8 *lun); 654 653 int pm8001_dev_found(struct domain_device *dev); 655 654 void pm8001_dev_gone(struct domain_device *dev);
-1
include/scsi/libsas.h
··· 636 636 /* Task Management Functions. Must be called from process context. */ 637 637 int (*lldd_abort_task)(struct sas_task *); 638 638 int (*lldd_abort_task_set)(struct domain_device *, u8 *lun); 639 - int (*lldd_clear_aca)(struct domain_device *, u8 *lun); 640 639 int (*lldd_clear_task_set)(struct domain_device *, u8 *lun); 641 640 int (*lldd_I_T_nexus_reset)(struct domain_device *); 642 641 int (*lldd_ata_check_ready)(struct domain_device *);