Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

reiserfs: clean-up function return type

Turn 'reiserfs_flush_old_commits()' into a void function because the callers
do not cares about what it returns anyway.

We are going to remove the 'sb->s_dirt' field completely and this patch is a
small step towards this direction.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

authored by

Artem Bityutskiy and committed by
Al Viro
25729b0e efaa33eb

+4 -6
+3 -5
fs/reiserfs/journal.c
··· 3492 3492 ** flushes any old transactions to disk 3493 3493 ** ends the current transaction if it is too old 3494 3494 */ 3495 - int reiserfs_flush_old_commits(struct super_block *sb) 3495 + void reiserfs_flush_old_commits(struct super_block *sb) 3496 3496 { 3497 3497 time_t now; 3498 3498 struct reiserfs_transaction_handle th; ··· 3502 3502 /* safety check so we don't flush while we are replaying the log during 3503 3503 * mount 3504 3504 */ 3505 - if (list_empty(&journal->j_journal_list)) { 3506 - return 0; 3507 - } 3505 + if (list_empty(&journal->j_journal_list)) 3506 + return; 3508 3507 3509 3508 /* check the current transaction. If there are no writers, and it is 3510 3509 * too old, finish it, and force the commit blocks to disk ··· 3525 3526 do_journal_end(&th, sb, 1, COMMIT_NOW | WAIT); 3526 3527 } 3527 3528 } 3528 - return sb->s_dirt; 3529 3529 } 3530 3530 3531 3531 /*
+1 -1
fs/reiserfs/reiserfs.h
··· 2452 2452 int reiserfs_end_persistent_transaction(struct reiserfs_transaction_handle *); 2453 2453 int reiserfs_commit_page(struct inode *inode, struct page *page, 2454 2454 unsigned from, unsigned to); 2455 - int reiserfs_flush_old_commits(struct super_block *); 2455 + void reiserfs_flush_old_commits(struct super_block *); 2456 2456 int reiserfs_commit_for_inode(struct inode *); 2457 2457 int reiserfs_inode_needs_commit(struct inode *); 2458 2458 void reiserfs_update_inode_transaction(struct inode *);