Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

MIPS: generic/yamon-dt: fix uninitialized variable error

In the case where fw_getenv returns an error when fetching values
for ememsizea and memsize then variable phys_memsize is not assigned
a variable and will be uninitialized on a zero check of phys_memsize.
Fix this by initializing phys_memsize to zero.

Cleans up cppcheck error:
arch/mips/generic/yamon-dt.c:100:7: error: Uninitialized variable: phys_memsize [uninitvar]

Fixes: f41d2430bbd6 ("MIPS: generic/yamon-dt: Support > 256MB of RAM")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

authored by

Colin Ian King and committed by
Thomas Bogendoerfer
255e51da b3ff2881

+1 -1
+1 -1
arch/mips/generic/yamon-dt.c
··· 75 75 __init int yamon_dt_append_memory(void *fdt, 76 76 const struct yamon_mem_region *regions) 77 77 { 78 - unsigned long phys_memsize, memsize; 78 + unsigned long phys_memsize = 0, memsize; 79 79 __be32 mem_array[2 * MAX_MEM_ARRAY_ENTRIES]; 80 80 unsigned int mem_entries; 81 81 int i, err, mem_off;