Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/fsl-dcu: fix opencoded use of drm_panel_*

Use drm_panel_get_modes() to access modes.
This has a nice side effect to simplify the code.

drm_panel_get_modes() may return a negative value if
for example panel is NULL. This is a small change
compared to before, but really what we want.

v2:
- Add more info to changelog (Stefan)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Cc: Alison Wang <alison.wang@nxp.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190804201637.1240-6-sam@ravnborg.org

+1 -9
+1 -9
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c
··· 65 65 static int fsl_dcu_drm_connector_get_modes(struct drm_connector *connector) 66 66 { 67 67 struct fsl_dcu_drm_connector *fsl_connector; 68 - int (*get_modes)(struct drm_panel *panel); 69 - int num_modes = 0; 70 68 71 69 fsl_connector = to_fsl_dcu_connector(connector); 72 - if (fsl_connector->panel && fsl_connector->panel->funcs && 73 - fsl_connector->panel->funcs->get_modes) { 74 - get_modes = fsl_connector->panel->funcs->get_modes; 75 - num_modes = get_modes(fsl_connector->panel); 76 - } 77 - 78 - return num_modes; 70 + return drm_panel_get_modes(fsl_connector->panel); 79 71 } 80 72 81 73 static int fsl_dcu_drm_connector_mode_valid(struct drm_connector *connector,