Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[SCSI] libsas: fix failure to revalidate domain for anything but the first expander child.

In an enclosure model where there are chaining expanders to a large body
of storage, it was discovered that libsas, responding to a broadcast
event change, would only revalidate the domain of first child expander
in the list.

The issue is that the pointer value to the discovered source device was
used to break out of the loop, rather than the content of the pointer.

This still remains non-compliant as the revalidate domain code is
supposed to loop through all child expanders, and not stop at the first
one it finds that reports a change count. However, the design of this
routine does not allow multiple device discoveries and that would be a
more complicated set of patches reserved for another day. We are fixing
the glaring bug rather than refactoring the code.

Signed-off-by: Mark Salyzyn <msalyzyn@us.xyratex.com>
Cc: stable@kernel.org
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

authored by

Mark Salyzyn and committed by
James Bottomley
24926dad d0efab26

+1 -1
+1 -1
drivers/scsi/libsas/sas_expander.c
··· 1721 1721 list_for_each_entry(ch, &ex->children, siblings) { 1722 1722 if (ch->dev_type == EDGE_DEV || ch->dev_type == FANOUT_DEV) { 1723 1723 res = sas_find_bcast_dev(ch, src_dev); 1724 - if (src_dev) 1724 + if (*src_dev) 1725 1725 return res; 1726 1726 } 1727 1727 }