Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mei: wd: rename watchdog constants to be more descriptive

1. rename defines to more be descriptive
2. remove duplicated defines from interface.h
3. add common prefix MEI_

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Tomas Winkler and committed by
Greg Kroah-Hartman
248ffdf7 c8df7292

+23 -26
-8
drivers/misc/mei/interface.h
··· 23 23 #include "mei_dev.h" 24 24 25 25 26 - #define AMT_WD_DEFAULT_TIMEOUT 120 /* seconds */ 27 - #define AMT_WD_MIN_TIMEOUT 120 /* seconds */ 28 - #define AMT_WD_MAX_TIMEOUT 65535 /* seconds */ 29 - 30 - #define MEI_WATCHDOG_DATA_SIZE 16 31 - #define MEI_START_WD_DATA_SIZE 20 32 - #define MEI_WD_PARAMS_SIZE 4 33 - 34 26 35 27 void mei_read_slots(struct mei_device *dev, 36 28 unsigned char *buffer,
+2 -2
drivers/misc/mei/interrupt.c
··· 1251 1251 dev->wd_pending = false; 1252 1252 1253 1253 if (dev->wd_timeout) 1254 - *slots -= mei_data2slots(MEI_START_WD_DATA_SIZE); 1254 + *slots -= mei_data2slots(MEI_WD_START_MSG_SIZE); 1255 1255 else 1256 - *slots -= mei_data2slots(MEI_WD_PARAMS_SIZE); 1256 + *slots -= mei_data2slots(MEI_WD_STOP_MSG_SIZE); 1257 1257 } 1258 1258 } 1259 1259 if (dev->stop)
+9 -4
drivers/misc/mei/mei_dev.h
··· 25 25 /* 26 26 * watch dog definition 27 27 */ 28 - #define MEI_WATCHDOG_DATA_SIZE 16 29 - #define MEI_START_WD_DATA_SIZE 20 30 - #define MEI_WD_PARAMS_SIZE 4 28 + #define MEI_WD_HDR_SIZE 4 29 + #define MEI_WD_STOP_MSG_SIZE MEI_WD_HDR_SIZE 30 + #define MEI_WD_START_MSG_SIZE (MEI_WD_HDR_SIZE + 16) 31 + 32 + #define MEI_WD_DEFAULT_TIMEOUT 120 /* seconds */ 33 + #define MEI_WD_MIN_TIMEOUT 120 /* seconds */ 34 + #define MEI_WD_MAX_TIMEOUT 65535 /* seconds */ 35 + 31 36 #define MEI_WD_STATE_INDEPENDENCE_MSG_SENT (1 << 0) 32 37 33 38 #define MEI_RD_MSG_BUF_SIZE (128 * sizeof(u32)) ··· 253 248 bool wd_stopped; 254 249 bool wd_bypass; /* if false, don't refresh watchdog ME client */ 255 250 u16 wd_timeout; /* seconds ((wd_data[1] << 8) + wd_data[0]) */ 256 - unsigned char wd_data[MEI_START_WD_DATA_SIZE]; 251 + unsigned char wd_data[MEI_WD_START_MSG_SIZE]; 257 252 258 253 259 254 struct file *iamthif_file_object;
+12 -12
drivers/misc/mei/wd.c
··· 48 48 static void mei_wd_set_start_timeout(struct mei_device *dev, u16 timeout) 49 49 { 50 50 dev_dbg(&dev->pdev->dev, "wd: set timeout=%d.\n", timeout); 51 - memcpy(dev->wd_data, mei_start_wd_params, MEI_WD_PARAMS_SIZE); 52 - memcpy(dev->wd_data + MEI_WD_PARAMS_SIZE, &timeout, sizeof(u16)); 51 + memcpy(dev->wd_data, mei_start_wd_params, MEI_WD_HDR_SIZE); 52 + memcpy(dev->wd_data + MEI_WD_HDR_SIZE, &timeout, sizeof(u16)); 53 53 } 54 54 55 55 /** ··· 66 66 67 67 /* look for WD client and connect to it */ 68 68 dev->wd_cl.state = MEI_FILE_DISCONNECTED; 69 - dev->wd_timeout = AMT_WD_DEFAULT_TIMEOUT; 69 + dev->wd_timeout = MEI_WD_DEFAULT_TIMEOUT; 70 70 71 71 /* find ME WD client */ 72 72 mei_me_cl_update_filext(dev, &dev->wd_cl, ··· 108 108 mei_hdr->msg_complete = 1; 109 109 mei_hdr->reserved = 0; 110 110 111 - if (!memcmp(dev->wd_data, mei_start_wd_params, MEI_WD_PARAMS_SIZE)) 112 - mei_hdr->length = MEI_START_WD_DATA_SIZE; 113 - else if (!memcmp(dev->wd_data, mei_stop_wd_params, MEI_WD_PARAMS_SIZE)) 114 - mei_hdr->length = MEI_WD_PARAMS_SIZE; 111 + if (!memcmp(dev->wd_data, mei_start_wd_params, MEI_WD_HDR_SIZE)) 112 + mei_hdr->length = MEI_WD_START_MSG_SIZE; 113 + else if (!memcmp(dev->wd_data, mei_stop_wd_params, MEI_WD_HDR_SIZE)) 114 + mei_hdr->length = MEI_WD_STOP_MSG_SIZE; 115 115 else 116 116 return -EINVAL; 117 117 ··· 138 138 return 0; 139 139 140 140 dev->wd_timeout = 0; 141 - memcpy(dev->wd_data, mei_stop_wd_params, MEI_WD_PARAMS_SIZE); 141 + memcpy(dev->wd_data, mei_stop_wd_params, MEI_WD_STOP_MSG_SIZE); 142 142 dev->stop = true; 143 143 144 144 ret = mei_flow_ctrl_creds(dev, &dev->wd_cl); ··· 315 315 return -ENODEV; 316 316 317 317 /* Check Timeout value */ 318 - if (timeout < AMT_WD_MIN_TIMEOUT || timeout > AMT_WD_MAX_TIMEOUT) 318 + if (timeout < MEI_WD_MIN_TIMEOUT || timeout > MEI_WD_MAX_TIMEOUT) 319 319 return -EINVAL; 320 320 321 321 mutex_lock(&dev->device_lock); ··· 349 349 static struct watchdog_device amt_wd_dev = { 350 350 .info = &wd_info, 351 351 .ops = &wd_ops, 352 - .timeout = AMT_WD_DEFAULT_TIMEOUT, 353 - .min_timeout = AMT_WD_MIN_TIMEOUT, 354 - .max_timeout = AMT_WD_MAX_TIMEOUT, 352 + .timeout = MEI_WD_DEFAULT_TIMEOUT, 353 + .min_timeout = MEI_WD_MIN_TIMEOUT, 354 + .max_timeout = MEI_WD_MAX_TIMEOUT, 355 355 }; 356 356 357 357