Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio: stmpe: don't print out global GPIO numbers in debugfs callbacks

In order to further limit the number of references to the GPIO base
number stored in struct gpio_chip, replace the global GPIO numbers in
the output of debugfs callbacks by hardware offsets.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250826-gpio-dbg-show-base-v1-1-7f27cd7f2256@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

+6 -8
+6 -8
drivers/gpio/gpio-stmpe.c
··· 262 262 stmpe_gpio->regs[REG_IE][regoffset] |= mask; 263 263 } 264 264 265 - static void stmpe_dbg_show_one(struct seq_file *s, 266 - struct gpio_chip *gc, 267 - unsigned offset, unsigned gpio) 265 + static void stmpe_dbg_show_one(struct seq_file *s, struct gpio_chip *gc, 266 + unsigned int offset) 268 267 { 269 268 struct stmpe_gpio *stmpe_gpio = gpiochip_get_data(gc); 270 269 struct stmpe *stmpe = stmpe_gpio->stmpe; ··· 285 286 286 287 if (dir) { 287 288 seq_printf(s, " gpio-%-3d (%-20.20s) out %s", 288 - gpio, label ?: "(none)", str_hi_lo(val)); 289 + offset, label ?: "(none)", str_hi_lo(val)); 289 290 } else { 290 291 u8 edge_det_reg; 291 292 u8 rise_reg; ··· 353 354 irqen = !!(ret & mask); 354 355 355 356 seq_printf(s, " gpio-%-3d (%-20.20s) in %s %13s %13s %25s %25s", 356 - gpio, label ?: "(none)", 357 + offset, label ?: "(none)", 357 358 str_hi_lo(val), 358 359 edge_det_values[edge_det], 359 360 irqen ? "IRQ-enabled" : "IRQ-disabled", ··· 365 366 static void stmpe_dbg_show(struct seq_file *s, struct gpio_chip *gc) 366 367 { 367 368 unsigned i; 368 - unsigned gpio = gc->base; 369 369 370 - for (i = 0; i < gc->ngpio; i++, gpio++) { 371 - stmpe_dbg_show_one(s, gc, i, gpio); 370 + for (i = 0; i < gc->ngpio; i++) { 371 + stmpe_dbg_show_one(s, gc, i); 372 372 seq_putc(s, '\n'); 373 373 } 374 374 }